Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie Settings Not Easily Discoverable #220

Closed
brianking opened this issue Nov 18, 2020 · 19 comments · Fixed by #1056 · May be fixed by #394
Closed

Cookie Settings Not Easily Discoverable #220

brianking opened this issue Nov 18, 2020 · 19 comments · Fixed by #1056 · May be fixed by #394
Assignees

Comments

@brianking
Copy link

brianking commented Nov 18, 2020

Once you accept or decline cookies, the bar minimizes to below the Github logo and repository name in the footer on the bottom left. It appears to look like a design element of the footer, and it is not obvious that you should hover it it to expand it and click to launch.

Screenshot 2020-11-18 at 12 22 07

I see it works the same way on eclipse.org, so it is by design. And the fix might not be here, but in the cookie module being used. However I thought I would call it out anyway.

@brianking
Copy link
Author

cc/ @chrisguindon if this has ever been flagged before, and if you have any thoughts on it.

@chrisguindon
Copy link
Member

@brianking Thanks for indirectly reporting a bug!

The badge should NOT be visible if we have a link to manage cookies on the page. I am currently working on a fix.

Our solution is to hide the minimized badge if there is a link on the page to manage cookies. That link must include the .toolbar-manage-cookies class.

@chrisguindon
Copy link
Member

chrisguindon commented Nov 18, 2020

@brianking We created a fix for this issue here:
EclipseFdn/solstice-assets#194

I hope to deploy this on www.eclipse.org later today.

The following code will display the banner whenever someone clicks on an HTML element with the class .toolbar-manage-cookies:
https://github.com/EclipseFdn/solstice-assets/blob/master/js/solstice.js#L171

The open-vsx website will need to implement something similar if they wish to hide the badge. Our code assumes that the site has jQuery. This will need to be re-written if they are not using that framework.

The badge is our fallback solution if the manage cookie link is missing from the page as we need to make sure that people can opt-out or opt-in at any time.

Please let me know if you have any questions about this.

@brianking
Copy link
Author

Thanks Chris. I'll leave it in the hands of @spoenemann to decide if the fix can be taken here.

@chrisguindon
Copy link
Member

@brianking Sounds good! This is now live on eclipse.org.

@spoenemann
Copy link
Contributor

I disabled the "Cookie settings" bar for now. Is it really necessary to allow users to revise their choice on cookies?

@chrisguindon
Copy link
Member

chrisguindon commented Dec 2, 2020 via email

@brianking
Copy link
Author

Ok so from what I can see, a 'Manage Cookies' link is outstanding to add here. As the footer is already crowded, I propose we add it to the user menu similar to how eclipse.org does it.

@chrisguindon
Copy link
Member

I agree. I think we should include it as we will probably want to add Google Analytics on the site to get some stats about how our users are using the site

@jbicker jbicker assigned jbicker and unassigned jbicker Mar 1, 2021
@jbicker
Copy link
Contributor

jbicker commented Mar 2, 2021

Hi, I can add an optional field in page settings for additional menu items to be rendered below the user name. So such a 'Manage Cookies' Button could be shown there, but only if the user is logged in. I guess the button should also be visible if the user is not logged in. I think about where to show the link in this case. To offer optional space to the right of the avatar (as it is almost on eclipse.org) is not a good solution in my eyes as there is no general need for such slots there.
Correct me if I am wrong. I am happy about your thoughts.

@jbicker
Copy link
Contributor

jbicker commented Mar 2, 2021

I talked with @spoenemann about it and we both think that the "Manage Cookies" Button would be best in footer. Since it is crowded as @brianking already mentioned we'd propose to generally hide some footer items in a dropdown (or is i called dropup in this case? :-) ) like it is for smaller window sizes.

@jbicker
Copy link
Contributor

jbicker commented Mar 3, 2021

@spoenemann @brianking it seems as if I do not have the permission to push here. Can you fix that? Thanks!

@chrisguindon
Copy link
Member

@jbicker From what I can tell, you do have write access to this repo.

@jbicker
Copy link
Contributor

jbicker commented Mar 3, 2021

@jbicker From what I can tell, you do have write access to this repo.

Ah yes, thanks. Works from local VSCode. Need authorization token for Gitpod.

Anyway I created #394 as a draft.
There is one question regarding the banner script:
are the respective handlers removed after first consent action? Because I am not able to use it a second time.

@chrisguindon
Copy link
Member

chrisguindon commented Mar 10, 2021

@jbicker This seems to work well on eclipse.org. You can't replicate that same behavior here?

@chrisguindon
Copy link
Member

@jbicker This seems to work well on eclipse.org. You can't replicate that same behavior here?

@autumnfound If you have time this week, can you take a look at helping @jbicker solve this issue.

@chrisguindon
Copy link
Member

chrisguindon commented Jun 7, 2022

@linkfang can you please create a "Manage Cookies" link in the footer toolbar that triggers our cookie consent banner when clicked on?

I believe the project is using our javascript script code. If so, you simply need to create a link with the class .toolbar-manage-cookies.

See source:
https://gitlab.eclipse.org/eclipsefdn/it/webdev/solstice-assets/-/blob/master/js/privacy/eclipsefdn.cookie-consent.js#L36

@kineticsquid
Copy link
Contributor

@chrisguindon we need this first before we can get info on visitors and downloads, right?

Do you want me to open a separate ticket for enabling the tracking?

@chrisguindon
Copy link
Member

chrisguindon commented Jun 8, 2022

@kineticsquid Indeed. We need to allow users to revoke our cookie consent banner before we can enable Google Analytics for the site.

+1 For creating a separate issue for installing GA. You can assign that one to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants