Show cookie settings by click on a respective button shown in footer #394
Conversation
chrisguindon
requested review from
autumnfound
and removed request for
chrisguindon
| } | ||
| })); | ||
|
|
||
| const FooterContent: React.FunctionComponent<{ expanded: boolean }> = ({ expanded }) => { | ||
| const classes = footerStyle(); | ||
| const theme = useTheme(); | ||
| const isSmallDisplay = useMediaQuery(theme.breakpoints.down('sm')); | ||
| const isSmallDisplay = useMediaQuery(theme.breakpoints.down('lg')); |
There was a problem hiding this comment.
we shouldn't change the definition of isSmallDisplay to encompass up to large displays, as this will trigger on many devices where it is not intentional. What was the reasoning behind this change?
There was a problem hiding this comment.
That variable is only to decide about the behaviour of the menu. Because I added the "Manage Cookies" item here, and the footer got too full for the lg size, I decided to switch to the collapsed menu in the footer at a larger state. Admittedly the naming of that variable is not suitable anymore.
|
@jbicker Is this something that still requires attention? |
Not as far as I know. |
A "Manage Cookies" link gets shown in footer. A click on it opens the cookie consent banner again.
Still work in progress:
Fixes #220