Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Hover Effect to Clarify Uneditable Links #10348

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

SohamRoy-01
Copy link
Member

Add Hover Effect for Explaining Uneditable Links

Fixes Issue :- #10215

Closes Issue :- #10215

Changes proposed

  • Implemented a hover effect to clarify uneditable links.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Note to reviewers

I've made adjustments to the code to accommodate specific circumstances. Please review the changes and let me know if anything further is needed. @eddiejaoude

@amandamartin-dev
Copy link
Contributor

Hey @SohamRoy-01 and @eddiejaoude - in looking back at this issue, I originally approved it thinking it was about the github profile link (which should not be edited as it's connected to your biodrop profile) However, on looking more closely - i see this is about the links page and a user SHOULD be able to edit their added links afaik.

This code is fine if we want it, but I'm confused as to why this field is blocked at all. Can anyone update me, am I missing something abotu why I should not be able to edit the url of a link that I have on my profile?

@eddiejaoude
Copy link
Member

Because the stats are collected against the url, we have it that the url for the links cannot be changed and therefore are disabled input fields.

The issue is meant to show to the user why the url for the link can't be edited

@amandamartin-dev
Copy link
Contributor

Because the stats are collected against the url, we have it that the url for the links cannot be changed and therefore are disabled input fields.

The issue is meant to show to the user why the url for the link can't be edited

Ah yes! It had been too long and I wasn't able to get that from the issue convo. Thanks Eddie!

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

But I left an inline comment about the message to the user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants