Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#8824 Edit button on manage links page added at right place #9886

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

#8824 Edit button on manage links page added at right place #9886

wants to merge 2 commits into from

Conversation

GauravLokhande16
Copy link

Fixes Issue

#8824 Edit button on manage links page added at right place

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.

Screenshots

Screenshot 2023-12-08 094535

@SaraJaoude SaraJaoude added the issue linked Pull Request has issue linked label Dec 11, 2023
@sital002 sital002 linked an issue Dec 13, 2023 that may be closed by this pull request
[FEATURE] Edit button on manage links page looks out of place #8824
Open
eddiejaoude
eddiejaoude requested changes Jan 11, 2024
View reviewed changes
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.

The package-lock.json file changes are not required, please remove these changes from your PR.

Also how does it effect other pages using the Edit component?

@hi-Kartik2004 hi-Kartik2004 mentioned this pull request Feb 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddiejaoude eddiejaoude eddiejaoude requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
issue linked Pull Request has issue linked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Edit button on manage links page looks out of place
3 participants
@GauravLokhande16 @eddiejaoude @SaraJaoude