[#308] Some Images missing "alt" property #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes EddieHubCommunity#308 This pull request addresses missing alt property in some images reported in EddieHubCommunity#308 . The changes iinclude setting the alt value to the name of the person testifying.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fi-krish
reviewed
Dec 17, 2023
src/components/Testimonials.jsx
Outdated
| @@ -129,7 +129,7 @@ export function Testimonials() { | |||
| testimonial.author.username + | |||
| '.png' | |||
| } | |||
| alt="" | |||
| alt={`${testimonial.author.name} image} | |||
There was a problem hiding this comment.
Suggested change
| alt={`${testimonial.author.name} image} | |
| alt={`${testimonial.author.name}'s profile picture`} |
adityaraute
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #308
This pull request addresses missing alt property in some images reported in #308 . The changes iinclude setting the alt value to the name of the person testifying.
Changes proposed
Check List (Check all the applicable boxes)