Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Enhance Sign Out Button #393

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

guptadeepak8
Copy link

Fixes Issue

This PR enhances the user interface for the "Sign Out" feature.It improves the visual design and overall user experience related to signing out.

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot (664)

Note to reviewers

Copy link

@aftabashraf003 aftabashraf003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enhanced the sign out button

@guptadeepak8
Copy link
Author

guptadeepak8 commented Nov 17, 2023

Hi @Cahllagerfeld, I've made some adjustments to align with the EddieHub CLI color scheme. Could you please review the changes and provide any feedback? Thanks!

Screenshot (665)

@Cahllagerfeld
Copy link
Member

I think we shouldn't make it that prominent, have a look how youtube does it for example.
My idea would be to work with a hover effect here, we should have the signout button a slightly different color from the background, and turn it orange on hover or something.

I'm keen on other opinions though 👍

@adityaraute
Copy link
Member

I think we shouldn't make it that prominent, have a look how youtube does it for example. My idea would be to work with a hover effect here, we should have the signout button a slightly different color from the background, and turn it orange on hover or something.

I agree, the sign out button stands out here, which is not necessary. I'd suggest a simple text color change like below works best.

Screenshots

Screenshot (664)

@Jumanjigobez
Copy link

@adityaraute,
Sorry I can't view the screenshot you shared kindly send it again.

@adityaraute
Copy link
Member

image
Here you go:
As was referenced by @guptadeepak8

But again, this is just my opinion, and I'm not the maintainer just so you know.

@Jumanjigobez
Copy link

ooh oops sorry I think it's my side is bad! But I agree also the button of sign out should be just a text with no background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants