This repository has been archived by the owner on Nov 25, 2022. It is now read-only.
Translation improvements #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rly. Also made a portuguese translation file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there
First of all thanks for providing this plugin, great work! I'm interested in using it for some projects and wanted to use a portuguese translation.
I looked into it and the translation was not working properly so I fixed it the way I could, looking into how other plugins were doing it. Not sure if it's the best way but I have tested it to some extent and it works nice. Also added in a portuguese translation file.
Since I started using github that I wanted to contribute in some way, altough I don't consider myself a great dev I feel that I have reached a point were I can start giving back something, so this is it!
It's my first PR here so please feel free to give me some tips on how to improve and be a better contributor.
I hope you appreciate this has I appreciate the effort you put into making this plugin!