Consider type of failure in Cause equality (#2653)

Effect-TS · Apr 29, 2024 · e79cb83 · e79cb83
1 parent 46b1327
commit e79cb83
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/.changeset/tender-clouds-wash.md b/.changeset/tender-clouds-wash.md
@@ -0,0 +1,5 @@
+---
+"effect": patch
+---
+
+Consider type of failure in Cause equality
diff --git a/packages/effect/src/internal/cause.ts b/packages/effect/src/internal/cause.ts
@@ -686,6 +686,7 @@ const evaluateCause = (
         break
       }
       case OpCodes.OP_FAIL: {
+        _parallel = HashSet.add(_parallel, cause._tag)
         _parallel = HashSet.add(_parallel, cause.error)
         if (stack.length === 0) {
           return [_parallel, _sequential]
@@ -694,6 +695,7 @@ const evaluateCause = (
         break
       }
       case OpCodes.OP_DIE: {
+        _parallel = HashSet.add(_parallel, cause._tag)
         _parallel = HashSet.add(_parallel, cause.defect)
         if (stack.length === 0) {
           return [_parallel, _sequential]
@@ -702,6 +704,7 @@ const evaluateCause = (
         break
       }
       case OpCodes.OP_INTERRUPT: {
+        _parallel = HashSet.add(_parallel, cause._tag)
         _parallel = HashSet.add(_parallel, cause.fiberId as unknown)
         if (stack.length === 0) {
           return [_parallel, _sequential]

diff --git a/packages/effect/test/Cause.test.ts b/packages/effect/test/Cause.test.ts
@@ -360,4 +360,8 @@ describe("Cause", () => {
       assert.strictEqual(Cause.pretty(Cause.fail([{ toString: "" }])), `Error: [{"toString":""}]`)
     })
   })
+
+  it("equals keep account for the failure type", () => {
+    expect(Equal.equals(Cause.die(0), Cause.fail(0))).toBe(false)
+  })
 })