Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSDoc typos in BooleanFromUnknown and split functions for Schema package #2583

Merged
merged 1 commit into from Apr 21, 2024

Conversation

suddenlyGiovanni
Copy link
Contributor

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Fix typos found in the JSDocs for split string transformation and BooleanFromUnknown boolean constructor functions.

fix typo for split string transformations

fix typo in `BooleanFromUnknown` comment

Two typos were spotted and corrected in the comments for the
`BooleanFromUnknown` interface in Schema.ts. "Convers" has been changed
to "Converts" and "convert" has been changed to "coerce" to improve the
clarity of the comment.

Signed-off-by: Giovanni Ravalico <15946771+suddenlyGiovanni@users.noreply.github.com>
Copy link

changeset-bot bot commented Apr 20, 2024

🦋 Changeset detected

Latest commit: 1fe925e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@effect/schema Patch
@effect/cli Patch
@effect/experimental Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/platform Patch
@effect/rpc-http Patch
@effect/rpc Patch
@effect/sql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gcanti gcanti merged commit 80271bd into Effect-TS:main Apr 21, 2024
12 checks passed
@gcanti
Copy link
Contributor

gcanti commented Apr 21, 2024

Thanks!

@github-actions github-actions bot mentioned this pull request Apr 21, 2024
@gcanti gcanti added the schema label Apr 21, 2024
@suddenlyGiovanni suddenlyGiovanni deleted the schema/typo-fix branch April 21, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants