typeclass - record - create SemigroupUnion, MonoidUnion and SemigroupIntersection #2635
+104
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dab28f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gcanti
reviewed
Apr 29, 2024
There was a problem hiding this comment.
I'd suggest adding a get prefix to align it with the current convention, for example, getSemigroupUnion.
I wonder how useful an instance for ReadonlyRecord<string | symbol, A> is. Generally, it's much more common to work with ReadonlyRecord<string, A>. Furthermore, the current implementation does not work with records with symbolic keys (Record.union only works with keys of type string).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
Creates
SemigroupUnion,MonoidUnionandSemigroupIntersectionforRecordI didn't create anything for
differenceas I didn't see the pointI didn't ceate a
Monoidforintersectionas I can't think of a logical empty element (I could do it with some kind of Proxy maybe ?)Related