Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added KeyValueStore.layerStorage #2737

Merged
merged 5 commits into from
May 30, 2024

Conversation

jessekelly881
Copy link
Contributor

@jessekelly881 jessekelly881 commented May 13, 2024

added platform KeyValueStore.layerStorage to create a KeyValueStore from an instance of the Storage type(e.g. SessionStorage and LocalStorage).

Thoughts on the pathOrDescriptor arg? I'm not sure if that's a good idea.

Copy link

changeset-bot bot commented May 13, 2024

🦋 Changeset detected

Latest commit: e10aeda

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@effect/platform Patch
@effect/cli Patch
@effect/experimental Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/rpc-http Patch
@effect/rpc Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-node Patch
@effect/sql Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tim-smart
Copy link
Member

Thoughts on the pathOrDescriptor arg? I'm not sure if that's a good idea.

You can just use the key as the path.

jessekelly881 and others added 2 commits May 29, 2024 05:54
Co-authored-by: Tim <hello@timsmart.co>
@tim-smart tim-smart merged commit 2c2280b into Effect-TS:main May 30, 2024
12 checks passed
@github-actions github-actions bot mentioned this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants