make Array.separate, Array.getRights, Array.getLefts, Array.getSomes heterogeneous
#2744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 91bcf99 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gcanti
requested changes
May 23, 2024
There was a problem hiding this comment.
I simplified the signatures (#2823) and added a few dtslint tests (#2825).
I would extend the same support to:
- getRights
- getLefts
- getSomes
Additionally, I would add the following dtslint tests (also for the other 3) to showcase the new capabilities:
// $ExpectType [(string | Date)[], (number | boolean)[]]
Array.separate(hole<Iterable<Either.Either<number, string> | Either.Either<boolean, Date>>>())
// $ExpectType [(string | Date)[], (number | boolean)[]]
Array.separate(hole<Iterable<Either.Either<number, string>> | Iterable<Either.Either<boolean, Date>>>())
added 8 commits
May 23, 2024 13:51
# Conflicts: # packages/effect/src/Array.ts
KhraksMamtsov
changed the title
Array.separate, Array.getRights, Array.getLefts, Array.getSomes heterogeneous
gcanti
reviewed
May 23, 2024
packages/effect/src/Array.ts
Outdated
| @@ -2254,7 +2254,14 @@ export const partitionMap: { | |||
| * @category filtering | |||
| * @since 2.0.0 | |||
| */ | |||
| export const getSomes: <A>(self: Iterable<Option<A>>) => Array<A> = filterMap(identity) | |||
|
|
|||
| export const getSomes: < | |||
There was a problem hiding this comment.
does this work as well?
export const getSomes: <T extends Iterable<Option<X>>, X = any>(
self: T
) => Array<Option.Value<ReadonlyArray.Infer<T>>> = filterMap(identity as any)
gcanti
approved these changes
May 23, 2024
|
@KhraksMamtsov thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
Related