Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Cause Rendering (Vitest) #2747

Merged
merged 8 commits into from
May 18, 2024
Merged

Conversation

mikearnaldi
Copy link
Member

@mikearnaldi mikearnaldi commented May 14, 2024

Screenshot 2024-05-15 at 13 47 40

Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: 04caa34

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
effect Minor
@effect/vitest Major
@effect/cli Major
@effect/experimental Major
@effect/opentelemetry Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc-http Major
@effect/rpc Major
@effect/schema Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mikearnaldi mikearnaldi marked this pull request as ready for review May 14, 2024 21:29
@tim-smart
Copy link
Member

This will likely create some merge conflicts with next-minor (with the span tracing changes), but I can resolve those 👍🏼

@Effect-TS Effect-TS deleted a comment from mikearnaldi May 15, 2024
@fubhy
Copy link
Member

fubhy commented May 15, 2024

/snapshot

Copy link
Contributor

github-actions bot commented May 15, 2024

Good news @fubhy, your snapshot has been published!

pnpm add @effect/cli@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add effect@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add @effect/experimental@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add @effect/opentelemetry@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add @effect/platform@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add @effect/platform-browser@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add @effect/platform-bun@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add @effect/platform-node@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add @effect/platform-node-shared@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add @effect/printer@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add @effect/printer-ansi@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add @effect/rpc@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add @effect/rpc-http@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add @effect/schema@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add @effect/sql@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add @effect/sql-mssql@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add @effect/sql-mysql2@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add @effect/sql-pg@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add @effect/sql-sqlite-bun@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add @effect/sql-sqlite-node@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add @effect/sql-sqlite-react-native@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add @effect/sql-sqlite-wasm@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add @effect/typeclass@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a
pnpm add @effect/vitest@0.0.0-snapshot-b4323ccacbf56b5c574bb69e7775d11cb8d2178a

You can review the build log here.

@github-actions github-actions bot changed the base branch from main to next-minor May 15, 2024 20:36
@mikearnaldi mikearnaldi changed the title Consider Generator.next a cutpoint Improve Cause Rendering (Vitest) May 15, 2024
@mikearnaldi
Copy link
Member Author

@tim-smart why did we end up with unrelated commits in this branch? Seems like a rebase issue

@tim-smart
Copy link
Member

@tim-smart why did we end up with unrelated commits in this branch? Seems like a rebase issue

Not sure. I ran another rebase against next-minor and it was clean. GitHub must struggle when the base branch also rebases.

@tim-smart tim-smart merged commit 388afeb into next-minor May 18, 2024
@tim-smart tim-smart deleted the feat/cutpoint-generator branch May 18, 2024 08:54
@github-actions github-actions bot mentioned this pull request May 18, 2024
github-actions bot pushed a commit that referenced this pull request May 19, 2024
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request May 19, 2024
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request May 19, 2024
Co-authored-by: Tim <hello@timsmart.co>
tim-smart added a commit that referenced this pull request May 20, 2024
Co-authored-by: Tim <hello@timsmart.co>
tim-smart added a commit that referenced this pull request May 20, 2024
Co-authored-by: Tim <hello@timsmart.co>
tim-smart added a commit that referenced this pull request May 20, 2024
Co-authored-by: Tim <hello@timsmart.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants