Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test build output before publishing #2759

Merged
merged 1 commit into from
May 19, 2024
Merged

Test build output before publishing #2759

merged 1 commit into from
May 19, 2024

Conversation

fubhy
Copy link
Member

@fubhy fubhy commented May 16, 2024

@tim-smart How about this? It's not a silver bullet, but it'd help detect potential issues with the build output. Since this only runs on changeset publish, it'd also not slow down our pipeline elsewhere.

Copy link

changeset-bot bot commented May 16, 2024

⚠️ No Changeset found

Latest commit: f9473e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fubhy
Copy link
Member Author

fubhy commented May 16, 2024

This assumes that some tests import from the root entrypoint. Which, I must admit, aren't that many.

Another option could be to generate snapshot tests for the exported symbols of all public modules. Basically just "dialing in" the public interface in a generated test case.

@tim-smart tim-smart merged commit 54d8580 into main May 19, 2024
12 checks passed
@tim-smart tim-smart deleted the testable-dist branch May 19, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants