Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct dirname for manifest #458

Merged
merged 1 commit into from
May 10, 2024

Conversation

josephnle
Copy link
Contributor

Description 馃摉

Uses path.dirname instead of path.basename so we correctly determine the manifestDir in the assets-manifest plugin.

Background 馃摐

This was happening because the package was using path.basename, which gives the file name and not the directory name.

The Fix 馃敤

Change path.basename to path.dirname

Screenshots 馃摲

N/A

@ElMassimo
Copy link
Owner

Thanks Joseph!

@ElMassimo ElMassimo merged commit cc46e3a into ElMassimo:main May 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants