fix: use correct dirname for manifest #458
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 馃摉
Uses
path.dirname
instead ofpath.basename
so we correctly determine themanifestDir
in the assets-manifest plugin.Background 馃摐
This was happening because the package was using
path.basename
, which gives the file name and not the directory name.The Fix 馃敤
Change
path.basename
topath.dirname
Screenshots 馃摲
N/A