Skip to content

Commit

Permalink
Revert "Fix UI corruption for AMD gpus with Vulkan (bevyengine#9169)"
Browse files Browse the repository at this point in the history
  • Loading branch information
Elabajaba committed Jul 22, 2023
1 parent eb485b1 commit d54fed3
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
7 changes: 1 addition & 6 deletions crates/bevy_ui/src/render/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ mod render_pass;

use bevy_core_pipeline::{core_2d::Camera2d, core_3d::Camera3d};
use bevy_hierarchy::Parent;
use bevy_render::view::Msaa;
use bevy_render::{ExtractSchedule, Render};
use bevy_window::{PrimaryWindow, Window};
pub use pipeline::*;
Expand Down Expand Up @@ -802,7 +801,6 @@ pub fn queue_uinodes(
ui_batches: Query<(Entity, &UiBatch)>,
mut views: Query<(&ExtractedView, &mut RenderPhase<TransparentUi>)>,
events: Res<SpriteAssetEvents>,
msaa: Res<Msaa>,
) {
// If an image has changed, the GpuImage has (probably) changed
for event in &events.images {
Expand All @@ -828,10 +826,7 @@ pub fn queue_uinodes(
let pipeline = pipelines.specialize(
&pipeline_cache,
&ui_pipeline,
UiPipelineKey {
hdr: view.hdr,
msaa_samples: msaa.samples(),
},
UiPipelineKey { hdr: view.hdr },
);
for (entity, batch) in &ui_batches {
image_bind_groups
Expand Down
3 changes: 1 addition & 2 deletions crates/bevy_ui/src/render/pipeline.rs
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ impl FromWorld for UiPipeline {
#[derive(Clone, Copy, Hash, PartialEq, Eq)]
pub struct UiPipelineKey {
pub hdr: bool,
pub msaa_samples: u32,
}

impl SpecializedRenderPipeline for UiPipeline {
Expand Down Expand Up @@ -118,7 +117,7 @@ impl SpecializedRenderPipeline for UiPipeline {
},
depth_stencil: None,
multisample: MultisampleState {
count: key.msaa_samples,
count: 1,
mask: !0,
alpha_to_coverage_enabled: false,
},
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_ui/src/render/render_pass.rs
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ impl Node for UiPassNode {
};
let mut render_pass = render_context.begin_tracked_render_pass(RenderPassDescriptor {
label: Some("ui_pass"),
color_attachments: &[Some(target.get_color_attachment(Operations {
color_attachments: &[Some(target.get_unsampled_color_attachment(Operations {
load: LoadOp::Load,
store: true,
}))],
Expand Down

0 comments on commit d54fed3

Please sign in to comment.