Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1434] Improve Shielding UX #1435

Merged
merged 3 commits into from
May 6, 2024
Merged

[#1434] Improve Shielding UX #1435

merged 3 commits into from
May 6, 2024

Conversation

HonzaR
Copy link
Collaborator

@HonzaR HonzaR commented May 3, 2024

These changes bring:

  • Show successful shielding attempt Toast
  • Actively trigger the balance refresh after the shielding (or sending) action is finished to shorten the time needed to refresh the transparent balance (and all balances too)

Note
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.

Author

  • Self-review your own code in GitHub's web interface1
  • Add automated tests as appropriate
  • Update the manual tests2 as appropriate
  • Check the code coverage3 report for the automated tests
  • Update documentation as appropriate (e.g README.md, Architecture.md, CHANGELOG.md, etc.)
  • Run the app and try the changes
  • Pull in the latest changes from the main branch and squash your commits before assigning a reviewer4

Note
It is good practice to provide before and after UI screenshots in the description of this PR. This is only applicable for changes that modify the UI.

Reviewer

  • Check the code with the Code Review Guidelines checklist
  • Perform an ad hoc review5
  • Review the automated tests
  • Review the manual tests
  • Review the documentation, README.md, Architecture.md, etc. as appropriate
  • Run the app and try the changes6

Footnotes

  1. Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.

  2. While we aim for automated testing of the application, some aspects require manual testing. If you had to manually test something during development of this pull request, write those steps down.

  3. While we are not looking for perfect coverage, the tool can point out potential cases that have been missed. Code coverage can be generated with: ./gradlew check for Kotlin modules and ./gradlew connectedCheck -PIS_ANDROID_INSTRUMENTATION_TEST_COVERAGE_ENABLED=true for Android modules.

  4. Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

  5. In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.

  6. While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data. Perform this step last, after verifying the code changes are safe to run locally.

- Closes #1434
- Changelog update
@HonzaR HonzaR requested a review from LukasKorba May 3, 2024 17:59
@HonzaR HonzaR added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. UI UI related tasks labels May 3, 2024
@HonzaR HonzaR force-pushed the 1434-improve-shielding-ux branch from d609541 to 54fe0f2 Compare May 4, 2024 12:50
Copy link
Collaborator

@LukasKorba LukasKorba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@HonzaR HonzaR merged commit 5c21a77 into main May 6, 2024
14 checks passed
@HonzaR HonzaR deleted the 1434-improve-shielding-ux branch May 6, 2024 14:33
@HonzaR HonzaR removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI UI related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Shielding UX
2 participants