Attempt to fix #2125 #2213
Open
Attempt to fix #2125 #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
me4502
reviewed
Nov 11, 2022
worldedit-core/src/main/java/com/sk89q/worldedit/internal/command/CommandUtil.java
Show resolved
Hide resolved
5 tasks
octylFractal
requested changes
Feb 20, 2023
Comment on lines
+232
to
+233
| // Ignore if suggestion ends with a " ", since that signals the end of | ||
| // the completed command. |
There was a problem hiding this comment.
Suggested change
| // Ignore if suggestion ends with a " ", since that signals the end of | |
| // the completed command. | |
| // Check if there is a space inside the substring, and suggest starting from there instead. |
|
Can you also rebase this onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the issue is that the block property completer adds two suggestions:
,, to start a new propertyname=valuepair.]and a trailing space, to signal that thats the end of the commandonlyOnLastQuotedWord()picks up on the trailing space, and attempts to limit the suggestion to the part behind the trailing space it. There is no part behind it, though - it's trailing after all. My fix was to simply ignore the trailing spaces.That should be looked over by someone who knows the internals and possible sideeffects from this change better than I do, though!