New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate bundled item data #2514
base: master
Are you sure you want to change the base?
Conversation
worldedit-core/src/main/java/com/sk89q/worldedit/world/registry/BundledItemRegistry.java
Outdated
Show resolved
Hide resolved
worldedit-core/src/main/java/com/sk89q/worldedit/world/registry/BundledItemData.java
Outdated
Show resolved
Hide resolved
worldedit-core/src/main/java/com/sk89q/worldedit/world/item/ItemType.java
Outdated
Show resolved
Hide resolved
@@ -24,6 +24,7 @@ | |||
import com.sk89q.worldedit.world.item.ItemType; | |||
import com.sk89q.worldedit.world.registry.BundledItemRegistry; | |||
|
|||
@SuppressWarnings("deprecation") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SuppressWarnings("deprecation") | |
@Deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class isn't deprecated
worldedit-core/src/main/java/com/sk89q/worldedit/world/registry/BundledItemData.java
Outdated
Show resolved
Hide resolved
worldedit-core/src/main/java/com/sk89q/worldedit/world/registry/BundledItemRegistry.java
Outdated
Show resolved
Hide resolved
@Nullable | ||
@SuppressWarnings("removal") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, any reference to something deprecated for removal is now erroring the build due to producing a warning, even if the current block is deprecated too
@@ -23,6 +23,8 @@ | |||
|
|||
import static com.sk89q.worldedit.util.GuavaUtil.firstNonNull; | |||
|
|||
@Deprecated(forRemoval = true) | |||
@SuppressWarnings("removal") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really needed?
@@ -19,5 +19,7 @@ | |||
|
|||
package com.sk89q.worldedit.world.registry; | |||
|
|||
@Deprecated(forRemoval = true) | |||
@SuppressWarnings("removal") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really needed?
This PR deprecates the concept of bundled item data, as well as the concept of "item material". This was added but never actually used. It's not very mod-compatible, and also requires storing increasingly large numbers of JSON files within the repo and jar files.
Due to the fact that WorldEdit never uses these at all, and that the bundled item registry is loaded when first accessed, this means we can remove the call to actually load it from WorldEdit. If something does happen to be using this deprecated API, it'll trigger it to be loaded upon first access.