Add get_bool_var for parsing boolean inputs #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnricoMi
requested changes
Dec 7, 2021
python/publish_unit_test_results.py
Outdated
| Same as get_var(), but checks if the value is a valid boolean. | ||
| If the value is unset, defaults to false. | ||
| """ | ||
| val = get_var(name, options).lower() |
There was a problem hiding this comment.
get_var can return None if name does not exist in options, then calling lower fails
There was a problem hiding this comment.
python/publish_unit_test_results.py
Outdated
| return default | ||
| elif val == 'true': | ||
| return True | ||
| elif val is 'false': |
The function raises an error when something other than true/false is used.
EnricoMi
force-pushed
the
ilent2-get-bool
branch
from
e82e750
to
e27d276
Compare
EnricoMi
changed the title
|
@ilent2 thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function prints a warning when something other than true/false is used. This fixes #194.