Fix and rework settings tests #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
EnricoMi
commented
Mar 7, 2022
•
EnricoMi
commented
- fixes regexp in is_alpha, extends testing
- fixes the way TEST_CHANGES_LIMIT is parsed
- harmonize parsing numbers in get_settings
- remove _default from test names, test all cases for each option
- compact options raising exceptions, use more loops and sub-tests
- move unknown value tests into specific option tests
- fixes regexp in is_alpha, extends testing - harmonize parsing numbers in get_settings - remove _default from test names, test all cases for each option - compact options raising exceptions, use more loops and sub-tests - move unknown value tests into specific option tests
Unit Test Results (Linux) 54 files ± 0 54 suites ±0 2m 32s ⏱️ -1s Results for commit c873e40. ± Comparison against base commit a57df58. This pull request removes 14 and adds 15 tests. Note that renamed tests count towards both. |
Unit Test Results (setup-python) 54 files ± 0 54 suites ±0 2m 32s ⏱️ -1s Results for commit c873e40. ± Comparison against base commit a57df58. This pull request removes 14 and adds 15 tests. Note that renamed tests count towards both. |
Unit Test Results (macOS) 54 files ± 0 54 suites ±0 2m 32s ⏱️ -1s Results for commit c873e40. ± Comparison against base commit a57df58. This pull request removes 14 and adds 15 tests. Note that renamed tests count towards both. |
Unit Test Results (Test Files) 25 files ±0 4 errors 22 suites ±0 39m 12s ⏱️ ±0s For more details on these parsing errors, failures and errors, see this check. Results for commit c873e40. ± Comparison against base commit a57df58. |
Unit Test Results (Dockerfile) 54 files ± 0 54 suites ±0 2m 32s ⏱️ -1s Results for commit c873e40. ± Comparison against base commit a57df58. This pull request removes 14 and adds 15 tests. Note that renamed tests count towards both. |
Unit Test Results (Windows) 54 files ± 0 54 suites ±0 2m 32s ⏱️ -1s Results for commit c873e40. ± Comparison against base commit a57df58. This pull request removes 14 and adds 15 tests. Note that renamed tests count towards both. |
Unit Test Results (Docker Image) 54 files ± 0 54 suites ±0 2m 32s ⏱️ -1s Results for commit c873e40. ± Comparison against base commit a57df58. This pull request removes 14 and adds 15 tests. Note that renamed tests count towards both. |
Unit Test Results (reference) 54 files ± 0 54 suites ±0 2m 32s ⏱️ -1s Results for commit c873e40. ± Comparison against base commit a57df58. This pull request removes 14 and adds 15 tests. Note that renamed tests count towards both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.