Handle malformed or empty config_changes.queue file #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If for whatever reason (ie: invalid JSON content or empty queue file) The JSON parser throws an exception, emits a warning and continues with an empty list References: BAR-151 Signed-off-by: Giulio Calacoci <giulio.calacoci@enterprisedb.com>
Signed-off-by: Giulio Calacoci <giulio.calacoci@enterprisedb.com>
barthisrael
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Changes look good. They even bring a self-healing mechanism which throws a WARNING just once, and fixes the issue:
$ barman cron
Starting WAL archiving for server pg
$ echo "" > barman_home/cfg_changes.queue
$ barman cron
WARNING: Malformed or empty configuration change queue: /home/vagrant/barman_home/cfg_changes.queue
Starting WAL archiving for server pg
$ barman cron
Starting WAL archiving for server pg
$ cat barman_home/cfg_changes.queue
[]
|
I know this is closed, but shouldn't we emit an output message as a warning when the queue file is not found? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If for whatever reason (ie: invalid JSON content or empty queue file)
The JSON parser throws an exception, emits a warning and continues with an
empty list
References: BAR-151