Handle if null initialization callback #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarsilv
commented
Apr 10, 2024
| @@ -167,6 +167,7 @@ public void onError(String errorMessage) { | |||
| }) | |||
| .buildAndInit(); | |||
|
|
|||
| // Wait for initialization to succeed or fail, up to 10 seconds, before continuing | |||
There was a problem hiding this comment.
unrelated, but threw in this helpful comment too
| @@ -4,7 +4,7 @@ plugins { | |||
| } | |||
|
|
|||
| group = "cloud.eppo" | |||
| version = "1.0.6" | |||
| version = "1.0.7" | |||
There was a problem hiding this comment.
Remembering to bump the version in the same PR! 🎉
| @@ -29,7 +29,9 @@ public void load(InitializationCallback callback) { | |||
| @Override | |||
| public void onCacheLoadSuccess() { | |||
| cachedUsed.set(true); | |||
| callback.onCompleted(); | |||
| if (callback != null) { | |||
There was a problem hiding this comment.
The fix
(The other two places already have it)
sameerank
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one spot--where we successfully load the configuration from the file cache--where we don't check if the initialization callback is defined before attempting to call it. This adds in that check.