Rework TestScope model to meet Servo's needs
#103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
force-pushed
the
align-test-scope
branch
from
2b1b260
to
23e21e4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
ErichDonGubler
commented
May 31, 2024
| browser: Browser, | ||
| visibility: TestVisibility, | ||
| pub(crate) enum ServoTestScope { | ||
| WebGpu, |
There was a problem hiding this comment.
From @sagudev on the commit (original link):
Maybe add some rustdoc comment that would describe variant. Something about that this is WebGPU CTS directory.
There was a problem hiding this comment.
This is nitpicking but source sounds wired to me in this context, maybe Servo tree or Servo repo would be more appropriate?
Disclaimer: I am NOT a native speaker.
…tead of `let-else`
ErichDonGubler
force-pushed
the
align-test-scope
branch
from
23e21e4
to
daa3f73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #92, I had suggested a new representation for
TestScopewhereBrowserandTestVisibilitywere two dimensions on which other products could integrate withmoz-webgpu-cts. However, that model is wrong; Servo only really has one set of paths and runner URLs that it cares about, currently. One can observe this with thetodo!()s that I merged in that PR. 😅 So, I'm fixing my mistake!Throw away
TestVisibilityand makeTestScopemirrorBrowservariants with additional, independent structure per-browser. Concretely, makeTestScopeuse either aFirefoxTestScopeor aServoTestScope, the latter of which only has aWebGpuvariant (for now).