DO NOT MERGE: Test targetless render pipelines #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#5691) * Avoid introducing spurious features for optional dependencies If a feature depends on an optional dependency without using the dep: prefix, a feature with the same name as the optional dependency is introduced. This feature almost certainly won't have any effect when enabled other than increasing compile times and polutes the feature list shown by cargo add. Consistently use dep: for all optional dependencies to avoid this problem. * Add changelog entry
…pdates (gfx-rs#5698) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- Document `LifetimeTracker::triage_resources`. - Fix various typos and bad grammar.
Check whether the resource is abandoned first, since none of the rest of the work is necessary otherwise. Rename `non_referenced_resources` to `last_resources`. This function copes with various senses in which the resource might be referenced or not. Instead, `last_resources` is the name of the `ActiveSubmission` member this may point to, which is more specific. Move the use of `last_resources` immediately after its production.
Rename `LifetimeTracker::triage_resources`'s `resources_map` argument to `suspected_resources`, since this always points to a field of `LifetimeTracker::suspected_resources`. In the various `triage_suspected_foo` functions, name the map `suspected_foos`.
A `for` loop is less noisy than a `drain`, which requires: - a `mut` qualifier for a variable whose modified value we never consult - a method name appearing mid-line instead of a control structure name at the front of the line - a range which is always `..`, establishing no restriction at all - a closure instead of a block Structured control flow syntax has a fine pedigree, originating in, among other places, Dijkstrsa's efforts at designing languages in a way that made it easier to formally verify programs written in them (see "A Discipline Of Programming"). There is nothing "more mathematical" about a method call that takes a closure than a `for` loop. Since `for_each` is useless unless the closure has side effects, there's nothing "more functional" about `for_each` here, either. Obsessive use of `for_each` suggests that the author loves Haskell without understanding it.
…buffer_f32_slice instead of clear (gfx-rs#5666) * Issue SetDrawColorBuffers commands before issuing ClearColor This is necessary for glClearBuffer calls to work correctly on some machines (e.g. AMD Renoir graphics running on Linux). Without this, glClearBuffer calls are ignored. * Use clear_buffer_f32_slice instead of gl.clear to suppress WebGL warnings This fixes the following WebGL warning: "WebGL warning: drawBuffers: `buffers[i]` must be NONE or COLOR_ATTACHMENTi." When using native OpenGL, it is acceptable to call glDrawBuffers with an array of buffers where i != COLOR_ATTACHMENTi. In WebGL, this is not allowed. * Run cargo fmt * Add changes for PR gfx-rsGH-5666 to the CHANGELOG
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.