Skip to content

Commit

Permalink
Switch from webpack to Parcel
Browse files Browse the repository at this point in the history
- Removed all webpack related configurations and dependencies
- Add parcel as dependency
- Moved static imagery to wwwroot as it's not longer moved as part of
the build process unless it's referenced directly in the CSS/TypeScript
- Needed to use `errorRecovery` option due to lightgallery using out of
date CSS techniques for clearfix - parcel-bundler/parcel#8352
- Removed content hashing using custom namer due to fonts being
preloaded in HTML, thus the name can't be changed for each build
- Rename output folders/filenames to match other team's approach
  • Loading branch information
peterkeating committed Oct 5, 2022
1 parent 80dd157 commit fb5d720
Show file tree
Hide file tree
Showing 31 changed files with 75 additions and 321 deletions.
4 changes: 3 additions & 1 deletion content/.gitignore
Expand Up @@ -35,8 +35,10 @@ msbuild.wrn

# Build artifacts

wwwroot/
wwwroot/css
wwwroot/scripts
dist/
**/.parcel-cache/

# Dependencies

Expand Down
7 changes: 7 additions & 0 deletions content/.parcelrc
@@ -0,0 +1,7 @@
{
"extends": "@parcel/config-default",
"namers": [
"parcel-namer-hashless",
"..."
]
}
Empty file.
4 changes: 2 additions & 2 deletions content/Assets/Styles/index.scss
Expand Up @@ -15,8 +15,8 @@
* https://necolas.github.io/normalize.css/
*/

@import '../../node_modules/normalize.css/normalize';
@import '../../node_modules/lightgallery.js/src/sass/lightgallery';
@import url('../../node_modules/normalize.css/normalize.css');
@import url('../../node_modules/lightgallery.js/src/sass/lightgallery.scss');

@import 'defaults/all';

Expand Down
2 changes: 1 addition & 1 deletion content/Assets/Styles/variables/_breakpoints.scss
Expand Up @@ -6,7 +6,7 @@
* Media query breakpoints used by sass-mq.
*/

$mq-breakpoints: (
$breakpoints: (
mobileSmall: 320px,
mobile: 375px,
mobileLarge: 425px,
Expand Down
8 changes: 0 additions & 8 deletions content/BuildConfigs/.stylelintrc

This file was deleted.

17 changes: 0 additions & 17 deletions content/BuildConfigs/tsconfig.json

This file was deleted.

3 changes: 0 additions & 3 deletions content/BuildConfigs/tslint.json

This file was deleted.

196 changes: 0 additions & 196 deletions content/BuildConfigs/webpack.config.js

This file was deleted.

25 changes: 0 additions & 25 deletions content/BuildConfigs/webpack.config.prod.js

This file was deleted.

4 changes: 2 additions & 2 deletions content/Etch.OrchardCore.ThemeBoilerplate.csproj
Expand Up @@ -56,10 +56,10 @@
</ItemGroup>

<Target Name="BuildStaticAssets" AfterTargets="PreBuildEvent" Condition="'$(Configuration)' == 'Debug'">
<Exec Command="npm run bundle:dev" />
<Exec Command="npm run build" />
</Target>

<Target Name="BuildStaticAssetsForRelease" AfterTargets="PreBuildEvent" Condition="'$(Configuration)' == 'Release'">
<Exec Command="npm run build" />
</Target>
</Project>
</Project>
22 changes: 9 additions & 13 deletions content/Views/Layout.liquid
Expand Up @@ -13,21 +13,17 @@
document.createElement( "picture" );
</script>

<link rel="preload" href="/Etch.OrchardCore.ThemeBoilerplate/fonts/manuale-v8-latin-regular.woff" as="font" type="font/woff" crossorigin="anonymous">
<link rel="preload" href="/Etch.OrchardCore.ThemeBoilerplate/fonts/manuale-v8-latin-regular.woff2" as="font" type="font/woff2" crossorigin="anonymous">
<link rel="preload" href="/Etch.OrchardCore.ThemeBoilerplate/fonts/manuale-v8-latin-700.woff" as="font" type="font/woff" crossorigin="anonymous">
<link rel="preload" href="/Etch.OrchardCore.ThemeBoilerplate/fonts/manuale-v8-latin-700.woff2" as="font" type="font/woff2" crossorigin="anonymous">
<link rel="preload" href="/Etch.OrchardCore.ThemeBoilerplate/fonts/manuale-v8-latin-italic.woff" as="font" type="font/woff" crossorigin="anonymous">
<link rel="preload" href="/Etch.OrchardCore.ThemeBoilerplate/fonts/manuale-v8-latin-italic.woff2" as="font" type="font/woff2" crossorigin="anonymous">
<link rel="preload" href="/Etch.OrchardCore.ThemeBoilerplate/fonts/work-sans-v9-latin-regular.woff" as="font" type="font/woff" crossorigin="anonymous">
<link rel="preload" href="/Etch.OrchardCore.ThemeBoilerplate/fonts/work-sans-v9-latin-regular.woff2" as="font" type="font/woff2" crossorigin="anonymous">
<link rel="preload" href="/Etch.OrchardCore.ThemeBoilerplate/fonts/work-sans-v9-latin-700.woff" as="font" type="font/woff" crossorigin="anonymous">
<link rel="preload" href="/Etch.OrchardCore.ThemeBoilerplate/fonts/work-sans-v9-latin-700.woff2" as="font" type="font/woff2" crossorigin="anonymous">
<link rel="preload" href="/Etch.OrchardCore.ThemeBoilerplate/fonts/work-sans-v9-latin-italic.woff" as="font" type="font/woff" crossorigin="anonymous">
<link rel="preload" href="/Etch.OrchardCore.ThemeBoilerplate/fonts/work-sans-v9-latin-italic.woff2" as="font" type="font/woff2" crossorigin="anonymous">
<link rel="preload" href="/Etch.OrchardCore.ThemeBoilerplate/css/manuale-v8-latin-regular.woff" as="font" type="font/woff" crossorigin="anonymous">
<link rel="preload" href="/Etch.OrchardCore.ThemeBoilerplate/css/manuale-v8-latin-regular.woff2" as="font" type="font/woff2" crossorigin="anonymous">
<link rel="preload" href="/Etch.OrchardCore.ThemeBoilerplate/css/manuale-v8-latin-700.woff" as="font" type="font/woff" crossorigin="anonymous">
<link rel="preload" href="/Etch.OrchardCore.ThemeBoilerplate/css/manuale-v8-latin-700.woff2" as="font" type="font/woff2" crossorigin="anonymous">
<link rel="preload" href="/Etch.OrchardCore.ThemeBoilerplate/css/work-sans-v9-latin-regular.woff" as="font" type="font/woff" crossorigin="anonymous">
<link rel="preload" href="/Etch.OrchardCore.ThemeBoilerplate/css/work-sans-v9-latin-regular.woff2" as="font" type="font/woff2" crossorigin="anonymous">
<link rel="preload" href="/Etch.OrchardCore.ThemeBoilerplate/css/work-sans-v9-latin-700.woff" as="font" type="font/woff" crossorigin="anonymous">
<link rel="preload" href="/Etch.OrchardCore.ThemeBoilerplate/css/work-sans-v9-latin-700.woff2" as="font" type="font/woff2" crossorigin="anonymous">

{% style src:"/Etch.OrchardCore.ThemeBoilerplate/css/styles.css", append_version:"true" %}
{% script src:"/Etch.OrchardCore.ThemeBoilerplate/js/scripts.js", append_version:"true", async: "true" %}
{% script src:"/Etch.OrchardCore.ThemeBoilerplate/scripts/index.js", append_version:"true", async: "true" %}

{% resources type: "HeadLink" %}
{% resources type: "Stylesheet" %}
Expand Down

0 comments on commit fb5d720

Please sign in to comment.