Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch event data from gCal API #696

Merged
merged 11 commits into from Nov 11, 2022
Merged

Fetch event data from gCal API #696

merged 11 commits into from Nov 11, 2022

Conversation

charliettaylor
Copy link
Contributor

Resolves #646

@vercel
Copy link

vercel bot commented Nov 9, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
acm-csuf-site ✅ Ready (Inspect) Visit Preview Nov 10, 2022 at 8:33PM (UTC)

@vercel vercel bot temporarily deployed to Preview November 9, 2022 10:01 Inactive
EthanThatOneKid
EthanThatOneKid requested changes Nov 9, 2022
View reviewed changes
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing progress 🤯, thank you for contributing this! I reviewed your changes and left some comments :)

src/routes/(site)/events/[query].json/+server.ts Outdated Show resolved Hide resolved
src/routes/(site)/events/[query].json/+server.ts Outdated Show resolved Hide resolved
src/lib/server/events/gcal.ts Outdated Show resolved Hide resolved
src/lib/server/events/gcal.ts Outdated Show resolved Hide resolved
src/lib/server/events/gcal.ts Outdated Show resolved Hide resolved
src/lib/server/events/gcal.ts Show resolved Hide resolved
src/lib/server/events/gcal.ts Outdated Show resolved Hide resolved
src/lib/server/events/ical.test.ts Show resolved Hide resolved
src/lib/server/events/ical.test.ts Outdated Show resolved Hide resolved
src/lib/server/events/gcal.ts Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview November 9, 2022 23:42 Inactive
@netlify
Copy link

netlify bot commented Nov 10, 2022 •
edited

❌ Deploy Preview for acmcsuf failed.

Name Link
🔨 Latest commit 1f5fb62
🔍 Latest deploy log https://app.netlify.com/sites/acmcsuf/deploys/636d5fe4307e700008061165

@vercel vercel bot temporarily deployed to Preview November 10, 2022 00:41 Inactive
@vercel vercel bot temporarily deployed to Preview November 10, 2022 01:02 Inactive
@vercel vercel bot temporarily deployed to Preview November 10, 2022 01:16 Inactive
EthanThatOneKid
EthanThatOneKid approved these changes Nov 10, 2022
View reviewed changes
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left you a few more comments 😎

src/lib/server/events/gcal.ts Outdated Show resolved Hide resolved
src/routes/(site)/events/[query].json/+server.ts Outdated Show resolved Hide resolved
src/routes/(site)/events/[query].json/+server.ts Outdated Show resolved Hide resolved
src/routes/(site)/events/[query].json/+server.ts Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview November 10, 2022 06:14 Inactive
@vercel vercel bot temporarily deployed to Preview November 10, 2022 09:29 Inactive
@vercel vercel bot temporarily deployed to Preview November 10, 2022 20:30 Inactive
@vercel vercel bot temporarily deployed to Preview November 10, 2022 20:33 Inactive
EthanThatOneKid
EthanThatOneKid approved these changes Nov 11, 2022
View reviewed changes
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let it rip, @Peekoe!

This PR looks great as far as I can see 😎

@charliettaylor charliettaylor merged commit a305bb8 into main Nov 11, 2022
EthanThatOneKid added a commit that referenced this pull request Nov 12, 2022
@EthanThatOneKid
Uninstalled rrule since unused after #696
fcbce76
EthanThatOneKid added a commit that referenced this pull request Nov 12, 2022
@EthanThatOneKid
package-lock.json hotfix (#705)
88a159b 
* Update package-lock.json

* Uninstalled rrule since unused after #696
@karnikaavelumani karnikaavelumani mentioned this pull request Nov 12, 2022
Closed
@jaasonw jaasonw deleted the fix/646 branch December 27, 2022 12:38
@EthanThatOneKid EthanThatOneKid mentioned this pull request Feb 24, 2023
Closed
@EthanThatOneKid EthanThatOneKid mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EthanThatOneKid EthanThatOneKid EthanThatOneKid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Events: Fetch event data from gCal API
2 participants
@charliettaylor @EthanThatOneKid