New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UVOL Refactor #10085
Open
CITIZENDOT
wants to merge
63
commits into
dev
Choose a base branch
from
uvol-refactor
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
UVOL Refactor #10085
+4,088
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CITIZENDOT
force-pushed
the
uvol-refactor
branch
from
April 23, 2024 14:54
5e2fa9e
to
e55b399
Compare
CITIZENDOT
force-pushed
the
uvol-refactor
branch
from
April 25, 2024 20:42
3657024
to
943a255
Compare
…ine into uvol-refactor
Dispose them properly after every track/change in track
…ine into uvol-refactor
Latest hookstate doesn't allow to modify state through proxy
DanielBelmes
requested changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- None of the node editors(new Uvol and Playlist) are updating snapshots/authoring layer so they are not being saved.
- Can't remove playlist component for some reason. No errors
- Changing playlist playmode is erroring (
TypeError: Cannot set properties of undefined (setting 'playMode') in EditorControlFunctions
).
Other than those. Playback looks good
Fixed these. But PlaylistComponent is supposed to be set on the VolumetricComponent at all times. Should we enforce it somehow? May be, deny remove when Volumetric is set on the entity? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps
PlaylistComponent ⬆️