Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UVOL Refactor #10085

Open
wants to merge 63 commits into
base: dev
Choose a base branch
from
Open

UVOL Refactor #10085

wants to merge 63 commits into from

Conversation

CITIZENDOT
Copy link
Collaborator

@CITIZENDOT CITIZENDOT commented Apr 21, 2024

Subtasks Checklist

  • Playlist Component
  • BufferDataContainer to track buffered/pending data
  • NodeEditor & basic pause/play logic
  • Geometry Buffering
  • Texture Buffering
    • KTX2 Buffering
    • Video Texture (needs QA)
  • Update geometry
    • Render geometry
    • Dispose previous geometries
  • Update textures
    • Render textures
    • Dispose previous textures
  • Autotune targets (geometry & textures)
  • QA

Breaking Changes

References

closes #insert number here

QA Steps

image
PlaylistComponent ⬆️

@CITIZENDOT CITIZENDOT marked this pull request as draft April 21, 2024 22:26
@CITIZENDOT CITIZENDOT marked this pull request as ready for review May 12, 2024 17:00
@CITIZENDOT CITIZENDOT requested a review from speigg May 12, 2024 17:02
Copy link
Contributor

@DanielBelmes DanielBelmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • None of the node editors(new Uvol and Playlist) are updating snapshots/authoring layer so they are not being saved.
  • Can't remove playlist component for some reason. No errors
  • Changing playlist playmode is erroring (TypeError: Cannot set properties of undefined (setting 'playMode') in EditorControlFunctions).
    Other than those. Playback looks good

@CITIZENDOT
Copy link
Collaborator Author

Fixed these.

But PlaylistComponent is supposed to be set on the VolumetricComponent at all times. Should we enforce it somehow? May be, deny remove when Volumetric is set on the entity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants