iR 594 Audit and add postprocessing effects #10108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dev: (42 commits) fix(magic-link): Fix guest identity provider removal upon login token validation and retain only the latest generated token (#10078) Support GLTF Authoring (#10088) fix getNestedChildren not snubing children (#10097) Ir 507 Refactor InteractableComponent and expose API (#10064) Remove AssetDatabaseType from Asset schema (#10095) Added Asset Database Type in schema (#10094) Updated argument of install-projects.js script Fix distance model deserialization having wrong type check (#10091) Add GLTF Scene Support (#10045) FileThumbnailJobState now unescapes file names and replaces whitespace characters with hyphens to avoid issues with escaped characters in thumbnail URLs not loading. Made changes to input and select components (#10081) Fixed a couple bugs in cronjob updating. (#10087) tailwind error view and other tailwind fixes (#10076) Improve mac os onboarding, disable minio, and update mediasoup (#10071) Break Up and Type GLTF Loader (#10044) update default scene ground plane to be a nicer colour Added check for aws rolearn rollback. Added `helm repo update` before `helm upgrade` commands (#10084) Added batch invalidation fields to builder helm ugprade command (#10083) Modal fixes & UI improvements (#10077) ... # Conflicts: # packages/spatial/src/renderer/effects/PostProcessing.ts # packages/spatial/src/renderer/functions/configureEffectComposer.ts
HexaField
changed the title
|
@MbfloydIR you have some errors on the checks here btw. Double check your commit hooks are running. |
DanielBelmes
requested changes
May 1, 2024
packages/editor/src/components/properties/PostProcessingSettingsEditor.tsx
Outdated
Show resolved
Hide resolved
packages/spatial/src/renderer/functions/configureEffectComposer.ts
Outdated
Show resolved
Hide resolved
packages/spatial/src/renderer/functions/configureEffectComposer.ts
Outdated
Show resolved
Hide resolved
… we can use texture loading hooks
HexaField
requested changes
May 2, 2024
packages/spatial/src/renderer/components/PostProcessingComponent.tsx
Outdated
Show resolved
Hide resolved
HexaField
requested changes
May 3, 2024
* dev: fix admin projects and build status modals and statuses (#10116) Add unique constraint to project name column (#10125) 9928 optimize asset builds (#9965) Physics API Abstraction (#10124) rework scene loaded state usage (#10127) Camera and Spectation are Event Sourced (#10130) Location GLTF State Cleanup (#10129) Add locationType menu (#10128) IR 465 ECS Materials (#10109) Fix scenestate references in playmode tool (#10126) Remove old ColliderComponent (#10122) GLTF ECS Loader (#10102) Systems without any pre/post/sub systems will no longer start out expanded (#10120) Updated the avatar radius and camera rotation (#10118) Fixed setup helm in dev-deploy (#10092) Fix interactable cursor style reactor (#10117) IR-1790 making the addComponent search box gain focus automatically when opening the addComponent popup (#10106) Update AddEditLocationModal.tsx (#10110) Update README.md (#10112) MountPoint/Grabbable/Link Components now add Interactables to the authoring layer, optimized useEffects to Systems/Components/Editors (#10105)
…t being used in a for loop any longer
HexaField
requested changes
May 7, 2024
packages/spatial/src/renderer/components/PostProcessingComponent.tsx
Outdated
Show resolved
Hide resolved
commented out SSGIEffect since it required the composure before it is available
|
closing in favour of continued work #10148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve PostProcessing API
Added the missing post processing effects
GodRaysEffect needs light source that is not available, so it is left out
The following effects are aded but no difference can be seen when applied
SMAAEffect
SSAOEffect
SSREffect
DepthOfFieldEffect
BloomEffect
SSGIEffect
TRAAEffect
MotionBlurEffect
ShockWaveEffect