Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IR 1900 ECS Plugin Parameters by Shader, Various Bugfixes #10136

Merged
merged 20 commits into from May 14, 2024
Merged

IR 1900 ECS Plugin Parameters by Shader, Various Bugfixes #10136

merged 20 commits into from May 14, 2024

Conversation

AidanCaruso
Copy link
Member

@AidanCaruso AidanCaruso commented May 7, 2024 •
edited

Summary

  • Replace obc shader references with plugin parameters by shader name, store them in the relevant component.
  • Convert BPCEM envmaps to this pattern so they play nice with other plugins
  • Tweak dithering components to utilize this pattern
  • Fix material editor texture modification
  • Fix material gltf exports
  • Added handling for missing material names

Subtasks Checklist

Breaking Changes

References

Closes the following
https://tsu.atlassian.net/browse/IR-1900
https://tsu.atlassian.net/browse/IR-2024
https://tsu.atlassian.net/browse/IR-2031

QA Steps

@AidanCaruso AidanCaruso marked this pull request as draft May 8, 2024 01:19
@AidanCaruso AidanCaruso changed the title IR 1900 ECS Plugin Parameters by Shader IR 1900 ECS Plugin Parameters by Shader, Various Bugfixes May 14, 2024
@AidanCaruso AidanCaruso marked this pull request as ready for review May 14, 2024 14:31
@dinomut1
Copy link
Member

are we waiting on something here? can this be merged?

@AidanCaruso AidanCaruso added this pull request to the merge queue May 14, 2024
Merged via the queue into dev with commit b965dcf May 14, 2024
13 checks passed
@AidanCaruso AidanCaruso deleted the ir-1900-obc-plugins branch May 14, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielBelmes DanielBelmes DanielBelmes approved these changes

@dinomut1 dinomut1 dinomut1 approved these changes

@HexaField HexaField Awaiting requested review from HexaField

@MichaelEstes MichaelEstes Awaiting requested review from MichaelEstes

Assignees
No one assigned
Labels
verified-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AidanCaruso @dinomut1 @DanielBelmes