-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for project manifest.json #10144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I added a new scene and it was not reflected in manifest.json.
- I renamed apartment scene and it was not reflected in manifest.json
You can rename a scene into an already existing scene and it fails in SQL but pushes to manifest. So default when no scenes are detected is no scenes key (edited) |
Restructuring into after hooks will take a bit of work, and I can just solve that one problem and we can use validators to ensure the data is compliant before it hits the mutation hooks. We can restructure the effects of hooks another time, but it is a good point to raise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Assuming Daniel's comments will be handled in a separate PR
Summary
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps