Fixed imports of vite.config.extension.ts from projects #9622
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Path that was being used for fs.existsSync was not correct, missing .ts on the end, so no extensions were being found or applied. Import of extensions from correct staticPath triggers a TypeError: TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" This is a known issue with vite importing from files in other packages in a monorepo: vitejs/vite#5370 For now, using the workaround of importing via the relative path. Switching to bun will apparently solve this.
HexaField
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Path that was being used for fs.existsSync was not correct, missing .ts on the end, so no extensions were being found or applied.
Import of extensions from correct staticPath triggers a TypeError: TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts"
This is a known issue with vite importing from files in other packages in a monorepo: vitejs/vite#5370
For now, using the workaround of importing via the relative path. Switching to bun will apparently solve this.
References
closes #insert number here
QA Steps