electron-builder: remove gconf dependencies from deb package #9512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build tested on Debian sid fresh install. https://nightly.link/Eugeny/tabby/actions/runs/8222819584 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @Eugeny, I hope you are doing well.
Gconf has been deprecated and is no longer available on new distro which make difficult to install Tabby. It's not very clear from electron-builder if
gconf2andgconf-serviceare still needed in some case. docs(https://www.electron.build/configuration/linux.html#debian-package-options) say:PR updating the docs about this subject says:
Anyway, electron does not seem to depend on gconf since electron/electron#19498. if I haven't missed anything, it should be safe to remove theses two packages from deb dependencies.
Fix #9457
Fix #9340
Fix #9219