add minor version and patch to AssemblyVersion #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefringeninja
force-pushed
the
minver-jotunheim
branch
from
7f3170e
to
3d18eb0
Compare
hayley-jean
requested changes
Dec 15, 2020
src/Directory.Build.props
Outdated
| </PropertyGroup> | ||
| <Target Name="UpdateAssemblyVersion" AfterTargets="MinVer"> | ||
| <PropertyGroup> | ||
| <AssemblyVersion>$(MinVerMajor).$(MinVerMinor).$(MinVerP→ |
thefringeninja
force-pushed
the
minver-jotunheim
branch
from
3d18eb0
to
f3d6997
Compare
|
Can you add some context about the reasoning and/or ramifications of this please? (could this mean that 21.3.10 and 21.3.11 will require assembly version redirects etc?) (For comparison: While V5 and V20 are clearly binary incompatible, and having the Major be in the AssemblyVersion would help with making that clear, historically 5.0.x have been interchangeable, and many people and things lean on that. I'm not even necessarily trying to veto such a change, just would like to have a declaration as to what can be expected in the CHANGELOG.md or something at least) |
hayley-jean
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.