Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement cluster connection. #32

Merged
merged 2 commits into from Sep 7, 2020
Merged

Implement cluster connection. #32

merged 2 commits into from Sep 7, 2020

Conversation

YoEight
Copy link
Member

@YoEight YoEight commented Aug 26, 2020

No description provided.

@YoEight YoEight marked this pull request as ready for review August 28, 2020 16:05
@ahjohannessen
Copy link

ahjohannessen commented Aug 29, 2020 •
edited

@YoEight FYI, grpc/grpc-java#7133 - Here is an example of how I register a name resolver in my fs2 based client.

@YoEight
Copy link
Member Author

YoEight commented Aug 31, 2020

Thanks for the pointer @ahjohannessen

@YoEight YoEight force-pushed the cluster-connection branch 2 times, most recently from 481f03d to 1f438d0 Compare September 1, 2020 21:27
@YoEight
Copy link
Member Author

YoEight commented Sep 1, 2020

I addressed the deprecation warning.

@YoEight YoEight mentioned this pull request Sep 2, 2020
Merged
hayley-jean
hayley-jean approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@hayley-jean hayley-jean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Only thing to note currently is that the client needs to catch NotLeaderException, and dispose and reconnect the connection to connect to the new leader.

@YoEight YoEight merged commit f707d61 into trunk Sep 7, 2020
@YoEight YoEight mentioned this pull request Sep 7, 2020
Closed
@YoEight YoEight deleted the cluster-connection branch June 27, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayley-jean hayley-jean hayley-jean approved these changes

@Lougarou Lougarou Awaiting requested review from Lougarou

Assignees

@YoEight YoEight

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YoEight @ahjohannessen @hayley-jean