Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dependency-review): comment summary only on failure #17

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

sparten11740
Copy link
Collaborator

@sparten11740 sparten11740 commented Feb 21, 2024

The action was adding a considerable amount of noise by commenting on every PR even on success (bug reported in actions/dependency-review-action#697)

  • this PR updates the action
  • and upstreams optimizations from hydra wrt running on push

Tested in https://github.com/ExodusMovement/exodus-hydra/pull/5787

@sparten11740 sparten11740 self-assigned this Feb 21, 2024
Copy link

@r4vn r4vn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sparten11740 sparten11740 merged commit ffa4283 into master Feb 21, 2024
1 check passed
@sparten11740 sparten11740 deleted the sparten11740/feat/only-comment-on-failure branch February 21, 2024 12:16
@mvayngrib
Copy link
Collaborator

ideally we also prove it posts a comment on failure

@sparten11740
Copy link
Collaborator Author

ideally we also prove it posts a comment on failure

copy that, will create a test PR

@sparten11740
Copy link
Collaborator Author

tested in https://github.com/ExodusMovement/exodus-hydra/pull/5792#issuecomment-1956617120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants