Deploy Checklist: New Expensify 2023-10-30 #30560

OSBotify · 2023-10-30T07:33:13Z

Release Version: 1.3.93-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

The text was updated successfully, but these errors were encountered:

Beamanator · 2023-10-30T08:08:47Z

Wrote this little script to help check off old items from new checklist:

function checkOffOldPRsOnNewChecklist(oldChecklist, newChecklist) {
    const oldPrNums = oldChecklist
        .trim()
        .split('\n')
        .map(prURL => prURL.substr(prURL.lastIndexOf('/') + 1));

    const output = newChecklist
        .trim()
        .split('\n')
        .map((prURL) => {
            const prNum = prURL.substr(prURL.lastIndexOf('/') + 1);
            const isChecked = prURL.toLowerCase().indexOf('[x]') >= 0 || oldPrNums.includes(prNum);
            const ghChecklistPrefix = isChecked ? '- [x] ' : '- [ ] ';

            return `${ghChecklistPrefix}https://github.com/Expensify/App/pull/${prNum}`;
        })
        .join('\n');

    // Copy new checklist with updated checked items to clipboard
    copy(output);
}

Beamanator · 2023-10-30T08:09:14Z

Output:

- [ ] https://github.com/Expensify/App/pull/23702
- [x] https://github.com/Expensify/App/pull/26605
- [x] https://github.com/Expensify/App/pull/27306
- [x] https://github.com/Expensify/App/pull/27429
- [x] https://github.com/Expensify/App/pull/27764
- [ ] https://github.com/Expensify/App/pull/27994
- [x] https://github.com/Expensify/App/pull/28296
- [x] https://github.com/Expensify/App/pull/28352
- [x] https://github.com/Expensify/App/pull/28381
- [ ] https://github.com/Expensify/App/pull/28587
- [x] https://github.com/Expensify/App/pull/28596
- [x] https://github.com/Expensify/App/pull/28887
- [x] https://github.com/Expensify/App/pull/28939
- [ ] https://github.com/Expensify/App/pull/29014
- [x] https://github.com/Expensify/App/pull/29095
- [x] https://github.com/Expensify/App/pull/29284
- [x] https://github.com/Expensify/App/pull/29315
- [ ] https://github.com/Expensify/App/pull/29338
- [ ] https://github.com/Expensify/App/pull/29434
- [x] https://github.com/Expensify/App/pull/29443
- [x] https://github.com/Expensify/App/pull/29643
- [x] https://github.com/Expensify/App/pull/29668
- [x] https://github.com/Expensify/App/pull/29757
- [ ] https://github.com/Expensify/App/pull/29765
- [x] https://github.com/Expensify/App/pull/29771
- [x] https://github.com/Expensify/App/pull/29785
- [ ] https://github.com/Expensify/App/pull/29848
- [x] https://github.com/Expensify/App/pull/29869
- [x] https://github.com/Expensify/App/pull/29891
- [x] https://github.com/Expensify/App/pull/29924
- [ ] https://github.com/Expensify/App/pull/29927
- [ ] https://github.com/Expensify/App/pull/29931
- [ ] https://github.com/Expensify/App/pull/29936
- [x] https://github.com/Expensify/App/pull/29952
- [x] https://github.com/Expensify/App/pull/29970
- [x] https://github.com/Expensify/App/pull/29989
- [x] https://github.com/Expensify/App/pull/30013
- [x] https://github.com/Expensify/App/pull/30029
- [ ] https://github.com/Expensify/App/pull/30049
- [x] https://github.com/Expensify/App/pull/30058
- [x] https://github.com/Expensify/App/pull/30071
- [x] https://github.com/Expensify/App/pull/30091
- [x] https://github.com/Expensify/App/pull/30099
- [x] https://github.com/Expensify/App/pull/30163
- [x] https://github.com/Expensify/App/pull/30164
- [ ] https://github.com/Expensify/App/pull/30186
- [ ] https://github.com/Expensify/App/pull/30192
- [x] https://github.com/Expensify/App/pull/30213
- [x] https://github.com/Expensify/App/pull/30226
- [x] https://github.com/Expensify/App/pull/30227
- [x] https://github.com/Expensify/App/pull/30234
- [x] https://github.com/Expensify/App/pull/30241
- [x] https://github.com/Expensify/App/pull/30243
- [x] https://github.com/Expensify/App/pull/30259
- [x] https://github.com/Expensify/App/pull/30260
- [x] https://github.com/Expensify/App/pull/30266
- [ ] https://github.com/Expensify/App/pull/30270
- [ ] https://github.com/Expensify/App/pull/30287
- [x] https://github.com/Expensify/App/pull/30301
- [x] https://github.com/Expensify/App/pull/30315
- [x] https://github.com/Expensify/App/pull/30317
- [x] https://github.com/Expensify/App/pull/30321
- [x] https://github.com/Expensify/App/pull/30327
- [x] https://github.com/Expensify/App/pull/30335
- [ ] https://github.com/Expensify/App/pull/30357
- [ ] https://github.com/Expensify/App/pull/30363
- [ ] https://github.com/Expensify/App/pull/30369
- [x] https://github.com/Expensify/App/pull/30379
- [x] https://github.com/Expensify/App/pull/30383
- [ ] https://github.com/Expensify/App/pull/30397
- [ ] https://github.com/Expensify/App/pull/30402
- [ ] https://github.com/Expensify/App/pull/30403
- [x] https://github.com/Expensify/App/pull/30406
- [ ] https://github.com/Expensify/App/pull/30417
- [x] https://github.com/Expensify/App/pull/30440
- [x] https://github.com/Expensify/App/pull/30450
- [ ] https://github.com/Expensify/App/pull/30461
- [ ] https://github.com/Expensify/App/pull/30462
- [x] https://github.com/Expensify/App/pull/30463
- [ ] https://github.com/Expensify/App/pull/30486
- [ ] https://github.com/Expensify/App/pull/30497
- [ ] https://github.com/Expensify/App/pull/30519
- [ ] https://github.com/Expensify/App/pull/30521
- [x] https://github.com/Expensify/App/pull/30522
- [ ] https://github.com/Expensify/App/pull/30534

OSBotify · 2023-10-30T08:19:48Z

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.93-0 🚀

kavimuru · 2023-10-30T14:13:28Z

Checking the past build
#29931
#30049
#30192
#30270
#30363
#30397
#30402
#30403
#30417
#30461

luacmartins · 2023-10-30T17:17:20Z

Checking off #30592. Demoted to NAB.

kavimuru · 2023-10-30T19:38:32Z

Regression is at 40%
#27994 failing with #30546
#28587,#29338,#30497 failing with #30578
#30521 and #29434 failing with #30584

kavimuru · 2023-10-30T22:40:10Z

Regression is at 70% progress
#27994 failing with #30546
#28587,#29338,#30497 failing with #30578
#30521 and #29434 failing with #30584
#23702 failing with #30610

mvtglobally · 2023-10-31T03:51:54Z

Regression is at 7%. We will wrap it up early EST

Unchecked PRs
#23702 failing with #30610. Blocker label removed, Ok to check it off?
#27994 failing with #30546. Blocker label removed, Ok to check it off?
#28587 failing with #30578

#30521 and #29434 failing with #30584. Repro in PROD. Checking off

Beamanator · 2023-10-31T07:27:45Z

It looks like there's only 1% left in testrail? It would be amazing if we could get this done this morning, but no worries of not possible

Beamanator · 2023-10-31T08:39:38Z

#23702 failing with #30610. Blocker label removed, Ok to check it off?
#27994 failing with #30546. Blocker label removed, Ok to check it off?

Great, yes! I checked these off 👍

Beamanator · 2023-10-31T08:42:24Z

#28587 failing with #30578

This has a fix PR here: #30559

I'll CP then check off the list

Julesssss · 2023-10-31T09:06:41Z

I checked off blocker #30593 as its only a console error. No need to block deploy. cc @rlinoz

kavimuru · 2023-10-31T11:13:25Z

Regression is completed.
One open blocker #30607
unchecked PR #28587 , Seems it is fixed with this CP #30559 (comment) - OK to check it off?

Beamanator · 2023-10-31T11:36:55Z

Thanks @kavimuru !

#30607 is being looked into currently 👍

unchecked PR #28587 , Seems it is fixed with this CP #30559 (comment) - OK to check it off?

Yes agreed, OK to check it off! 👍

Beamanator · 2023-10-31T11:38:21Z

@kavimuru just checking, did you test #30559 on all platforms? I only tested on Web so far and it's passing

kavimuru · 2023-10-31T11:47:24Z

@Beamanator I will test in other platform and update.

Beamanator · 2023-10-31T11:49:38Z

Thank so much @kavimuru ! 🙏

kavimuru · 2023-10-31T12:08:49Z

@Beamanator It's a pass in all other platforms but Android. If this is expected as per this comment #30559 (comment), good to check it off.

Beamanator · 2023-10-31T12:16:59Z

Niiice, thanks for testing & pointing that out, let's check it off!! 👍

Beamanator · 2023-10-31T20:54:36Z

#30607 checked off b/c it was fixed with https://github.com/Expensify/Auth/pull/9088 & tested well in staging 👍

One more DP was added so I'll try to look now!

Beamanator · 2023-10-31T21:12:49Z

Checking off #30644 (comment) b/c we agreed it's NAB! That's the last deploy blocker!

Beamanator · 2023-10-31T21:21:18Z

OSBotify added the StagingDeployCash label Oct 30, 2023

OSBotify assigned applausebot Oct 30, 2023

Beamanator mentioned this issue Oct 30, 2023

Race condition can cause big checklists #27123

Closed

Beamanator added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Oct 30, 2023

Beamanator self-assigned this Oct 30, 2023

Beamanator closed this as completed Oct 31, 2023

Beamanator mentioned this issue Nov 1, 2023

Deploy Checklist: New Expensify 2023-10-31 #30662

Closed

97 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deploy Checklist: New Expensify 2023-10-30 #30560

Deploy Checklist: New Expensify 2023-10-30 #30560

OSBotify commented Oct 30, 2023 •

edited by Beamanator

Beamanator commented Oct 30, 2023

Beamanator commented Oct 30, 2023 •

edited

OSBotify commented Oct 30, 2023

kavimuru commented Oct 30, 2023

luacmartins commented Oct 30, 2023

kavimuru commented Oct 30, 2023

kavimuru commented Oct 30, 2023

mvtglobally commented Oct 31, 2023

Beamanator commented Oct 31, 2023

Beamanator commented Oct 31, 2023 •

edited

Beamanator commented Oct 31, 2023

Julesssss commented Oct 31, 2023

kavimuru commented Oct 31, 2023

Beamanator commented Oct 31, 2023

Beamanator commented Oct 31, 2023

kavimuru commented Oct 31, 2023

Beamanator commented Oct 31, 2023

kavimuru commented Oct 31, 2023

Beamanator commented Oct 31, 2023

Beamanator commented Oct 31, 2023

Beamanator commented Oct 31, 2023

Beamanator commented Oct 31, 2023

Deploy Checklist: New Expensify 2023-10-30 #30560

Deploy Checklist: New Expensify 2023-10-30 #30560

Comments

OSBotify commented Oct 30, 2023 • edited by Beamanator

Beamanator commented Oct 30, 2023

Beamanator commented Oct 30, 2023 • edited

OSBotify commented Oct 30, 2023

kavimuru commented Oct 30, 2023

luacmartins commented Oct 30, 2023

kavimuru commented Oct 30, 2023

kavimuru commented Oct 30, 2023

mvtglobally commented Oct 31, 2023

Beamanator commented Oct 31, 2023

Beamanator commented Oct 31, 2023 • edited

Beamanator commented Oct 31, 2023

Julesssss commented Oct 31, 2023

kavimuru commented Oct 31, 2023

Beamanator commented Oct 31, 2023

Beamanator commented Oct 31, 2023

kavimuru commented Oct 31, 2023

Beamanator commented Oct 31, 2023

kavimuru commented Oct 31, 2023

Beamanator commented Oct 31, 2023

Beamanator commented Oct 31, 2023

Beamanator commented Oct 31, 2023

Beamanator commented Oct 31, 2023

OSBotify commented Oct 30, 2023 •

edited by Beamanator

Beamanator commented Oct 30, 2023 •

edited

Beamanator commented Oct 31, 2023 •

edited