-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] Add orderWeight to tag view and tag edit routes #42149
[NoQA] Add orderWeight to tag view and tag edit routes #42149
Conversation
Adding NoQA because this PR is not fully testable yet and requires API commands to be added first namely the one to enable/disable tags and to rename tags. |
@s77rt @hayata-suenaga do we need a c+ review here? |
@s77rt, could you make a PR against this branch -> https://github.com/Expensify/App/tree/qbo-freeze-branch? 🙇 |
Done! |
Thank you! |
c684b64
into
Expensify:qbo-freeze-branch
[NoQA] Add orderWeight to tag view and tag edit routes
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.77-11 🚀
|
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.77-11 🚀
|
Details
Fixed Issues
$ #42056
PROPOSAL:
Tests
Preconditions:
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
Networking issue
iOS: Native
ios.mov
iOS: mWeb Safari
mweb-safari.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov