fix: [Search v1] Search page scroll is not smooth #42170

charles-liang · 2024-05-14T20:16:11Z

@eh2077

Details

#41581 [$250] [Search v1] Search page scroll is not smooth

Fixed Issues

$ #41581 (comment)
PROPOSAL: #41581 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the search page, Profile > Troubleshoot > New Search Page
Scroll through the list of results
Notice that the items flicker and on mobile the list jumps around

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

untitled.webm

Android: mWeb Chrome

android.mov

iOS: Native

ios-native.mov

iOS: mWeb Safari

ios.mov

MacOS: Chrome / Safari

2024-05-14.01.13.09.2.mov

2024-05-14.01.13.46.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-05-14T20:16:16Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2024-05-14T20:16:22Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

charles-liang · 2024-05-14T20:23:04Z

@eh2077
I compiled to Android native and iOS native, but I don't know how to switch the .env file.
I tried hardcoding isDeveloping to open the test menu, entered the Search Page, but couldn't load the data.
Can you tell me how I should test on these two platforms, or if it's not necessary to test right now?

charles-liang · 2024-05-14T20:24:19Z

I have read the CLA Document and I hereby sign the CLA

charles-liang · 2024-05-14T20:25:17Z

@bot

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

recheck

eh2077 · 2024-05-15T09:59:20Z

@eh2077 I compiled to Android native and iOS native, but I don't know how to switch the .env file. I tried hardcoding isDeveloping to open the test menu, entered the Search Page, but couldn't load the data. Can you tell me how I should test on these two platforms, or if it's not necessary to test right now?

@charles-liang Do you mean trying to open the search page on native Apps? If so, I think you can just follow the first reproduction step from the original issue

Open the search page, Profile > Troubleshoot > New Search Page

eh2077 · 2024-05-15T10:00:38Z

@charles-liang Can you handle the conflicts?

eh2077 · 2024-05-15T10:06:32Z

@charles-liang And don’t worry if CI workflows are not running automatically. It needs help from @luacmartins to trigger it because it's your first PR and it's a little bit special.

You can run lint, prettier and typecheck locally before pushing.

charles-liang · 2024-05-15T15:42:14Z

@eh2077 I compiled to Android native and iOS native, but I don't know how to switch the .env file. I tried hardcoding isDeveloping to open the test menu, entered the Search Page, but couldn't load the data. Can you tell me how I should test on these two platforms, or if it's not necessary to test right now?

@charles-liang Do you mean trying to open the search page on native Apps? If so, I think you can just follow the first reproduction step from the original issue

Open the search page, Profile > Troubleshoot > New Search Page

I mean i run it in iOS
And android native will use production env and cannot enter in search page because it only open in dev or staging
I don't know how to change it in the script.

eh2077 · 2024-05-15T15:55:22Z

I don't think it's necessary to edit .env file. Can you follow

to run native apps?

eh2077 · 2024-05-15T15:59:12Z

@charles-liang When opening a PR, please merge your branch to the main branch` as stated here

eh2077 · 2024-05-15T16:01:45Z

I mean i run it in iOS And android native will use production env and cannot enter in search page because it only open in dev or staging I don't know how to change it in the script.

I think the issue you encountered here is because you're not working on the main branch which contains default settings of dev env.

charles-liang · 2024-05-16T08:50:47Z

@eh2077 I have completed the iOS and Android native screenshots. The conflicts have also been resolved and merged into the main branch. Thank you for tutoring me.

eh2077 · 2024-05-16T14:07:00Z

src/components/Search.tsx

+            windowSize={111}
+            updateCellsBatchingPeriod={200}


Can you explain the rationale for choosing these values?

The windowSize is set to 111 because each page can contain a maximum of 500 items, and this size is sufficiently large to ensure that the entire page will not be recycled.

The choice of 200 for updateCellsBatchingPeriod is because 200ms out of 1000ms allows it to be slightly larger, preventing continuous loading while not causing too much delay.

Should we use different values for desktop and mobile devices? As their screens size are different

Recycling of cells is only necessary in cases such as phones with low memory. I tested in iPhone 14 pro is very smooth and not need recycling.

why I set it to 111. This size ensures that in both portrait mode and landscape mode, is large enough not to be recycled.

can we leave a comment explaining that please?

src/components/SelectionList/TransactionListItem.tsx

eh2077 · 2024-05-16T15:05:41Z

src/components/SelectionList/BaseSelectionList.tsx

+                rightHandSideComponent={
+                    rightHandSideComponent &&
+                    (typeof rightHandSideComponent === 'function'
+                        ? rightHandSideComponent({} as TItem) // Example usage of the function, replace with actual item
+                        : rightHandSideComponent)
+                }


Why do we need this change?

It's from the original code, and then when the GitHub Action runs typecheck, it throws a type error.

eh2077 · 2024-05-19T16:28:34Z

I'll continue testing when the site is full recovered.

eh2077 · 2024-05-20T14:00:07Z

@charles-liang I'm checkout this branch locally and still can't open search page.

charles-liang · 2024-05-20T15:05:50Z

Can you open the Chrome Developer Tools' Network tab to check the server response speed? I thought the network was slow because I am in China and there is a firewall.

eh2077 · 2024-05-20T15:12:06Z

I also tested on the main branch and it was same - loading. But the staging env is working. So, I'm going to revisit this after the merging freeze.

trjExpensify · 2024-05-20T15:23:43Z

@eh2077 can you open the console and head to the Network tab before you go to search page. Then look for the Search command and check if you're getting errors. I wonder if you're running into something I did recently with a 501 for an invalid tax percentage.

eh2077 · 2024-05-20T15:37:11Z

@trjExpensify Oh, sorry I forgot to attach the screenshot of request. Yeah, the backend returned invalid data though the HTTP code is 200.

cc @charles-liang

charles-liang · 2024-05-20T15:42:16Z

So？ what do I need to do? I feel like it's not an issue with my code.

eh2077 · 2024-05-20T15:50:12Z

So？ what do I need to do? I feel like it's not an issue with my code.

@charles-liang In this case, I think you can just wait until I'm able to re-test it and then provide feedback. Thanks.

@trjExpensify Should we pull in another internal engineer (since @luacmartins is OOO) to take a look at the API issue, or should we just wait a little while?

luacmartins · 2024-05-21T05:51:13Z

@eh2077 @charles-liang the pagination API is only in staging and we have a merge freeze in place. We'll need to wait a bit longer to get that deployed to production. Meanwhile, you should be able to test this using the staging API. Let me know if you still have issues with that.

charles-liang · 2024-05-23T15:38:43Z

@charles-liang please avoid force-pushing changes to the branch as that makes it a bit harder to review the code

@luacmartins

Should I rebase my branch onto the main branch and then make changes? Or should I merge the latest code from the main branch into my branch?

My approach is to rebase my branch onto the main branch and I can remember the specific changes I need to make. Then, I would force-push my branch in the end. This way, when comparing with the latest main branch, the diff will be very clean.

@eh2077@luacmartins Got it. I will pay attention to it in the future.

src/components/SelectionList/TransactionListItem.tsx

… for Cell Component

src/components/SelectionList/BaseSelectionList.tsx

src/components/Search.tsx

eh2077 · 2024-05-26T14:06:48Z

src/components/SelectionList/types.ts

+    updateCellsBatchingPeriod?: number;
+
+    /**
+     * The number passed here is a measurement unit where 1 is equivalent to your viewport height. The default value is 21 (10 viewports above, 10 below, and one in between).


The default value is 5 right?

This comment was copied from the original documentation. It is correct. The default value of 5 was used in the previous project.

src/components/SelectionList/types.ts

src/components/Search.tsx

src/components/SelectionList/TransactionListItem.tsx

eh2077 · 2024-05-27T16:14:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

0-android.mp4

Android: mWeb Chrome

0-mobile-chrome.mp4

iOS: Native

0-ios.mp4

iOS: mWeb Safari

0-mobile-safari.mp4

MacOS: Chrome / Safari

0-web.mp4

MacOS: Desktop

0-desktop.mp4

eh2077 · 2024-05-27T16:25:36Z

@luacmartins This PR overall looks good to me and tested well. Just defer one comment (about fixing type error from main) to you. Kindly help to trigger the workflow to see if CI is green, thanks!

luacmartins · 2024-05-27T16:29:01Z

Running workflow now.

luacmartins · 2024-05-27T16:49:20Z

@eh2077 seems like typecheck is passing.

luacmartins · 2024-05-27T18:25:19Z

src/components/SelectionList/TransactionListItem.tsx

                                <Icon
                                    src={Expensicons.ArrowRightLong}
                                    width={variables.iconSizeXXSmall}
                                    height={variables.iconSizeXXSmall}
                                    fill={theme.icon}
                                />
-                                <View style={[styles.flex1, styles.mw50]}>{userCell(transactionItem.to)}</View>
+                                <View style={[styles.mw50]}>


We need the styles.flex1 here otherwise the text overflows. I won't block on this though, since it's a simple change we can do in a follow up and it's more important to get this optimization out and resolve conflicts on ongoing PRs.

OSBotify · 2024-05-27T19:02:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-29T09:43:03Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T21:25:52Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T22:37:50Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

charles-liang requested a review from a team as a code owner May 14, 2024 20:16

melvin-bot bot requested review from eh2077 and removed request for a team May 14, 2024 20:16

luacmartins self-requested a review May 15, 2024 00:33

OSBotify force-pushed the staging branch from b5f3804 to 76846da Compare May 15, 2024 09:41

charles-liang changed the base branch from staging to main May 15, 2024 16:09

charles-liang force-pushed the charles branch from 60f91ea to 79fe0f8 Compare May 15, 2024 18:23

eh2077 reviewed May 16, 2024

View reviewed changes

eh2077 reviewed May 23, 2024

View reviewed changes

src/components/SelectionList/TransactionListItem.tsx Outdated Show resolved Hide resolved

fix: [Search v1] Search page scroll is not smooth; remove Memo Prefix…

7537123

… for Cell Component

eh2077 reviewed May 23, 2024

View reviewed changes

src/components/SelectionList/BaseSelectionList.tsx Show resolved Hide resolved

src/components/Search.tsx Outdated Show resolved Hide resolved

eh2077 suggested changes May 26, 2024

View reviewed changes

charles-liang added 3 commits May 27, 2024 09:59

fix: [Search v1] Search page scroll is not smooth; add eh2077 suggestion

d0b4a9f

fix: [Search v1] Search page scroll is not smooth; add eh2077 suggestion

50ecf11

Merge remote-tracking branch 'origin'

6034aee

luacmartins requested a review from eh2077 May 27, 2024 16:49

luacmartins approved these changes May 27, 2024

View reviewed changes

eh2077 approved these changes May 27, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins May 27, 2024 18:31

luacmartins approved these changes May 27, 2024

View reviewed changes

puneetlath merged commit a1cb473 into Expensify:main May 27, 2024
18 of 19 checks passed

github-actions bot mentioned this pull request May 27, 2024

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #42665

Closed

charles-liang deleted the charles branch May 27, 2024 22:46

luacmartins mentioned this pull request May 28, 2024

[Search v1] Improve performance of ReportListItem #42720

Open

6 tasks

github-actions bot mentioned this pull request May 29, 2024

Deploy Checklist: New Expensify 2024-05-29 #42741

Closed

jnowakow mentioned this pull request May 29, 2024

[HOLD for App #42772] Add snapshot functionality Expensify/react-native-onyx#552

Open

42 tasks

Krishna2323 mentioned this pull request May 29, 2024

[HOLD for payment 2024-06-06] [$250] Chat - Display Name Appears Black and Members Not Ticked in Group Preview #42751

Open

6 tasks

melvin-bot bot mentioned this pull request May 30, 2024

[HOLD for payment 2024-06-06] [$250] [Search v1] Search page scroll is not smooth #41581

Open

6 tasks

jnowakow mentioned this pull request Jun 3, 2024

Fix rendering TransactionListItemRow #42986

Draft

50 tasks

fix: [Search v1] Search page scroll is not smooth #42170

fix: [Search v1] Search page scroll is not smooth #42170

Conversation

charles-liang commented May 14, 2024 • edited

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 14, 2024

github-actions bot commented May 14, 2024 • edited

charles-liang commented May 14, 2024

charles-liang commented May 14, 2024

charles-liang commented May 14, 2024

eh2077 commented May 15, 2024

eh2077 commented May 15, 2024

eh2077 commented May 15, 2024

charles-liang commented May 15, 2024 • edited

eh2077 commented May 15, 2024

eh2077 commented May 15, 2024

eh2077 commented May 15, 2024 • edited

charles-liang commented May 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

charles-liang May 16, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eh2077 commented May 19, 2024

eh2077 commented May 20, 2024

charles-liang commented May 20, 2024

eh2077 commented May 20, 2024

trjExpensify commented May 20, 2024

eh2077 commented May 20, 2024 • edited

charles-liang commented May 20, 2024

eh2077 commented May 20, 2024

luacmartins commented May 21, 2024

charles-liang commented May 23, 2024

Choose a reason for hiding this comment

charles-liang May 27, 2024 • edited

Choose a reason for hiding this comment

eh2077 commented May 27, 2024 • edited

Reviewer Checklist

Screenshots/Videos

eh2077 commented May 27, 2024

luacmartins commented May 27, 2024

luacmartins commented May 27, 2024

Choose a reason for hiding this comment

OSBotify commented May 27, 2024

OSBotify commented May 29, 2024

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

charles-liang commented May 14, 2024 •

edited

github-actions bot commented May 14, 2024 •

edited

charles-liang commented May 15, 2024 •

edited

eh2077 commented May 15, 2024 •

edited

charles-liang May 16, 2024 •

edited

eh2077 commented May 20, 2024 •

edited

charles-liang May 27, 2024 •

edited

eh2077 commented May 27, 2024 •

edited