Add strict record checking. #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liach
reviewed
Mar 20, 2022
| AccessWidener.Access classAccess = accessWidener.getClassAccess(name); | ||
|
|
||
| if (strictRecords && "java/lang/Record".equals(superName) && AccessWidener.ClassAccess.isExtendable(classAccess)) { | ||
| throw new UnsupportedOperationException(String.format("Cannot modify record (%s) access to be extendable", name)); |
There was a problem hiding this comment.
Should we fail explicitly or simply ignore these, like what we are doing with interface static fields? non-final interface static fields cause classfile format errors when loaded by jvm, but record violations apparently won't hurt the jvm class loading.
There was a problem hiding this comment.
I think ingore now 👍Crashing like this now would really need a major version bump. With v3 we can possibly have something this strict.
Loom's validator should really fail on both of this situations (and possibly more): https://github.com/FabricMC/fabric-loom/blob/dev/0.12/src/main/java/net/fabricmc/loom/task/ValidateAccessWidenerTask.java#L97
I tottaly forgot about this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record classes cannot be made extendable.
Record fields that match a component cannot be made mutable.
I added this an option (on by default) to allow disabling this check incase the record components do not match the field names + desc.