Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build script to support Gradle 9 / fix deprecations added in 8.2 #244

Merged
merged 3 commits into from
Mar 27, 2023
Merged

Update build script to support Gradle 9 / fix deprecations added in 8.2 #244

merged 3 commits into from
Mar 27, 2023

Conversation

modmuss50
Copy link
Member

@modmuss50 modmuss50 commented Mar 20, 2023

As of recent Gradle 8.2 nightlys using plugin conventions have been deprecated and now raise a warning when building. This PR moves to the replacement in preperation for Gradle 9.

See:

https://github.com/gradle/gradle/blob/6ac87a4aa8756b70c74bc08d3b7156112ff81f61/subprojects/docs/src/docs/userguide/migration/upgrading_version_8.adoc#deprecated-access-to-plugin-conventions

and

gradle/gradle#24231

@modmuss50 modmuss50 added the enhancement New feature or request label Mar 20, 2023
Copy link
Member

@Juuxel Juuxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: This has also been the way it's done in the Kotlin DSL since the beginning, so it's also good for learning to use both DSLs.

Copy link
Member

@Juuxel Juuxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a Property?

build.gradle Outdated Show resolved Hide resolved
@modmuss50 modmuss50 merged commit 3935c0f into FabricMC:1.19 Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants