Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Image.php #881

Open
wants to merge 1 commit into
base: 2.0
Choose a base branch
from
Open

Update Image.php #881

wants to merge 1 commit into from

Conversation

ngdream
Copy link

@ngdream ngdream commented May 2, 2024

i fixed some bug in faker image provider

What is the reason for this PR?

  • A new feature
  • Fixed an issue (resolve #ID)

Author's checklist

Summary of changes

Review checklist

  • All checks have passed
  • Changes are added to the CHANGELOG.md
  • Changes are approved by maintainer

i fixed some bug in faker image provider
@pimjansen
Copy link

I would easier consider this as unsecure though to not verify the handshake of an external resource

@ngdream
Copy link
Author

ngdream commented May 3, 2024

I would easier consider this as unsecure though to not verify the handshake of an external resource

I would easier consider this as unsecure though to not verify the handshake of an external resource

This security prevented me and other developers from retrieving images using $faker->image() and I spent days trying to figure out how to fix this error

just check these links
https://stackoverflow.com/questions/72454513/how-to-generate-and-download-images-in-storage-using-laravels-faker

https://stackoverflow.com/questions/72585447/trouble-with-faker-class-in-laravel

https://stackoverflow.com/questions/57589055/images-created-with-factory-faker-get-deleted-when-stored-in-storage-public-imag

@ngdream
Copy link
Author

ngdream commented May 3, 2024

the solution i propose is in the last link

@ngdream
Copy link
Author

ngdream commented May 8, 2024

@pimjansen please could you please give your opinion

the solution i propose is in the last link

@pimjansen please could you give your opinion about this ??

@pimjansen
Copy link

The image provider is deprecated and we wont fix it. Add your own custom provider if needed.

The proposed solution is not acceptable because it is not acceptable not to verify ssl peers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants