Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm script to update snapshots. #82

Merged
merged 2 commits into from
Sep 30, 2021
Merged

Add npm script to update snapshots. #82

merged 2 commits into from
Sep 30, 2021

Conversation

demiankatz
Copy link
Collaborator

@demiankatz demiankatz commented Sep 23, 2021

TODO:

  • Make the script actually work right

@demiankatz
Copy link
Collaborator Author

@diboy2, I need to regenerate snapshots to make the tests pass in #72. I thought it would be useful to have an npm script to do this (and so it could be more easily documented). However, the code as written here isn't working, and I'm not sure what I'm missing. Can you point me in the right direction?

@demiankatz
Copy link
Collaborator Author

Thanks for your help on our call, @diboy2 -- if you like this as-is, feel free to hit merge when time permits. If you think it would be better for the script name to include "test" I'm happy to adjust. Just being lazy for now and keeping things mostly the way I set them up originally.

@Geoffsc Geoffsc merged commit 89b489b into dev Sep 30, 2021
@demiankatz demiankatz deleted the snapshots-script branch September 2, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants