Refactor metadata extraction to a separate class. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
force-pushed
the
refactor-metadata-extraction
branch
from
3ccd8c8
to
833d6e7
Compare
|
The new MetadataExtractor class would also be an excellent candidate for a unit test; we should start building out the api-side framework for that soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I think about the next steps on #72, it occurs to me that it would be useful to have access to metadata extraction capabilities independent of the hierarchy collector. It is also better separation of concerns to split hierarchy collection and metadata extraction into separate classes. This PR takes care of the split, adds some missing function comments, and removes an unused class property.