Improve error tolerance; prevent over-caching. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@diboy2, @Geoffsc -- this PR contains a couple of indexing fixes (including the caching-related one) which were necessary to get the index to update correctly following creation of objects through #72. However, since these fixes are not really directly related to #72, I split them out to a separate pull request. As @diboy2 suggested on our call, it would probably be a good idea to revisit our datastream caching logic (and determine whether it is even needed at all). However, until we have time to get that done, I would like to merge this so that things will function correctly in the meantime. I will put in a TODO comment as a reminder to find a better solution. Any objections to merging this as-is? |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.