Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies20230123 #110

Merged
merged 9 commits into from Jan 30, 2023
Merged

Update dependencies20230123 #110

merged 9 commits into from Jan 30, 2023

Conversation

tkmcmaster
Copy link
Contributor

- Cleaned up the start-at to only parse once
- Fixed the multiple --include. Clap no longer allows multiple occurences, it only allows multiple passed on one occurence. See clap-rs/clap#2688 and https://github.com/clap-rs/clap/blob/master/CHANGELOG.md#400---2022-09-28
- This does introduce a bug that if you specify the config file immediately after --include(s) it will think it's part of the --include. The user must either pass another option after -i or put the config file before the -i
Copy link
Contributor

@summersjc summersjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming all tests pass looks ok

@summersjc
Copy link
Contributor

Can't you add more files to this?

@tkmcmaster
Copy link
Contributor Author

Can't you add more files to this?

We can, but merging this doesn't release so we can create a new PR with new files. This one is just updated dependencies (and changes required by lint and updates).

@tkmcmaster
Copy link
Contributor Author

The Windows Test Suite is hanging on a single test in Github Actions but passes running locally (on Windows).

@tkmcmaster tkmcmaster merged commit 2fe329d into master Jan 30, 2023
@tkmcmaster tkmcmaster deleted the updateDependencies20230123 branch January 30, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants