Skip to content

Commit

Permalink
Merge pull request #69 from FasterXML/tatu/2.18/68-rm-junit4-dep
Browse files Browse the repository at this point in the history
Fix #68: change junit4 dep from regular to managed
  • Loading branch information
cowtowncoder committed Apr 21, 2024
2 parents 7ce93dd + ee58c28 commit ed1b496
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 13 deletions.
20 changes: 8 additions & 12 deletions base/pom.xml
Expand Up @@ -35,18 +35,6 @@ of Jackson: application code should only rely on `jackson-bom`
<project.build.outputTimestamp>2024-02-27T01:23:07Z</project.build.outputTimestamp>
</properties>

<dependencies>
<dependency> <!-- all components use junit for testing -->
<!-- 19-Feb-2024, tatu: This is for JUnit4 and we'll be migrating
to JUnit5 finally... so this will be dropped at some point
-->
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>${version.junit}</version>
<scope>test</scope>
</dependency>
</dependencies>

<dependencyManagement>
<dependencies>
<!-- JPMS Libraries-->
Expand All @@ -63,6 +51,14 @@ of Jackson: application code should only rely on `jackson-bom`
<version>${version.assertj}</version>
<scope>test</scope>
</dependency>
<!-- JUnit4 still used for many components (but not core) -->
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>${version.junit}</version>
<scope>test</scope>
</dependency>

<!-- Starting to migrate to JUnit5 -->
<dependency>
<groupId>org.junit</groupId>
Expand Down
3 changes: 2 additions & 1 deletion release-notes/VERSION-2.x
Expand Up @@ -11,7 +11,8 @@ Jackson components (core, modules)

2.18.0 (not yet released)

No changes since 2.17
#68: Remove `junit` 4.x dependency from `jackson-base` 2.18.x to help
junit5 migration

2.17.0 (12-Mar-2024)

Expand Down

0 comments on commit ed1b496

Please sign in to comment.