Support for sorted trees

[digulla]

This patch moves the factory for ObjectNode's children to the JsonNodeFactory.

Along with a new deepCopy() method in JsonNodeFactory, this allows to create sorted trees from the mapper or sort existing trees by copying them with a JsonNodeFactory where sorting is enabled.

There was a problem with TestJDKSerialization but that could be fixed very easily with just adding an interface which merges Serializable and Supplier<T>; Java then knows what to do.

[digulla]

Since you implemented sorting in a different way, I'll close this one.

[cowtowncoder]

Ok; I was considering accepting this too, but hadn't formed an opinion yet -- it is a valid approach too (and bit more powerful). But just for canonical JSON probably not worth pursuing at this point.

[digulla]

Okay, I thought this one was breaking too much. Reopened. Take your time.

[digulla]

Turns out the problem with TestJDKSerialization was very simple to fix. This now starts to look promising.

[yawkat]

why is JsonNodeFactory serializable?

[cowtowncoder]

It is referenced by ObjectMapper (part of configurarion not transient state) which needs to be serializable

…

On Mon, Jun 26, 2023 at 9:23 AM Jonas Konrad ***@***.***> wrote: why is JsonNodeFactory serializable? — Reply to this email directly, view it on GitHub <#3995 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAANOGI3E6AUVTEWHMQCDNTXNETHZANCNFSM6AAAAAAZLBPT3A> . You are receiving this because you commented.Message ID: ***@***.***>

[digulla]

Looks like the trick doesn't work on Android.

Options left:

• Accept this flaw if it's not an important feature for Android.
• If it's important but not urgent, postpone the fix for Android but give it everyone else
• If this isn't acceptable, we can try a custom serializer which knows how to restore the two common cases and fails for others
• or a new interface which extends Serializable and implements Supplier itself and then we do two proper implementations without lambdas.

Which way do you want to go?

[yawkat]

why does this not work on android?

[cowtowncoder]

Looks like there is a failure for "animal-sniffer" plugin, which is used to guard against unintended changes to levels of Android SDK that jackson-databind depends on. I'll see if I can reproduce the problem.