Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JavaDoc for config ACCEPT_EMPTY_STRING_AS_NULL_OBJECT wrt special cases #4010

Closed
wants to merge 4 commits into from

Conversation

JooHyukKim
Copy link
Member

relates to #4009

}

final ObjectMapper DISABLED_MAPPER = newJsonMapper()
.configure(DeserializationFeature.ACCEPT_EMPTY_STRING_AS_NULL_OBJECT, false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not need to be set on mapper; could set on ObjectReader instead?

@cowtowncoder
Copy link
Member

Hmmh. I think that this behavior should be changed for 2.16, see my notes on #4009.

What could be done here would be:

  1. Change to target 2.15, to verify then-current behavior of coercion
  2. Remove Javadoc comment, or make it suggest that there are gray areas; but NOT establish behavior wrt java.util.Local given change for 2.16.

If test was added, it would then be modified as part of #4009 for 2.16.

@JooHyukKim
Copy link
Member Author

Hmmh. I think that this behavior should be changed for 2.16, see my notes on #4009.

Oh yes I just read the comment 👍🏻.

  1. Change to target 2.15, to verify then-current behavior of coercion

WIll do.

  1. Remove Javadoc comment, or make it suggest that there are gray areas; but NOT establish behavior wrt java.util.Local given change for 2.16.

Will remove reference to Locale.

@JooHyukKim JooHyukKim changed the base branch from 2.16 to 2.15 July 4, 2023 23:47
@JooHyukKim JooHyukKim changed the base branch from 2.15 to 2.16 July 4, 2023 23:47
@JooHyukKim
Copy link
Member Author

For safe verion control, I will not test my git skills rebasing from 2.16 to.2.15 😅 and close this one and cherry pick the changes back.

@JooHyukKim JooHyukKim closed this Jul 4, 2023
@cowtowncoder
Copy link
Member

Sorry about this. I have not figure out how to use rebase properly with Github PRs in cases like this. :-(

@JooHyukKim
Copy link
Member Author

Np! I don't think there is legit clean way to do such thing, speaking from logical perspective 😆

@cowtowncoder
Copy link
Member

Yeah I guess at the point PR is created it is bound to specified branch as... base?
It's just unfortunate that while creating PR it is simple enough to see what diffs were merged, based on target, and this is no longer available once created.

@JooHyukKim JooHyukKim deleted the 4009-JavaDoc-improve branch July 5, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants