issue-1770 - big number not returned as DecimalNode #4191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update NumberNodes1770Test.java Update NumberNodes1770Test.java
pjfanning
force-pushed
the
big-number-issue
branch
from
cd3cc18
to
1fcc82a
Compare
cowtowncoder
reviewed
Nov 8, 2023
| try { | ||
| return _fromBigDecimal(ctxt, nodeFactory, p.getDecimalValue()); | ||
| } catch (NumberFormatException nfe) { | ||
| // fall through - BigDecimal does not support values like NaN |
There was a problem hiding this comment.
I don't think this makes sense -- this is an error condition and we should report an error shouldn't we?
(existing code was wrong already, I think)
There was a problem hiding this comment.
Actually, let me re-think -- should probably merge this as suggested but file a follow-up issue to consider making it fail as expected.
And possibly do that with configurable JsonNodeFeature setting.
cowtowncoder
reviewed
Nov 8, 2023
cowtowncoder
approved these changes
Nov 8, 2023
|
Thank you @pjfanning ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1770
also see FasterXML/jackson-core#1135
Makes the failing test
NumberNodes1770TestpassBreaks another test -
NotANumberConversionTest.testBigDecimalWithNaN- I have added a hack to this PR to fix that test. BigDecimal does not support NaN value.